Skip to content

Commit 54f2d21

Browse files
authored
chore: Add TODO comment (#2587)
Signed-off-by: Ian Lewis <[email protected]>
1 parent ca80026 commit 54f2d21

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

internal/builders/nodejs/build.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ echo "Directory '${UNTRUSTED_DIRECTORY}' resolved to '${untrusted_realpath}'"
3030
github_workspace_realpath=$(realpath -e "${GITHUB_WORKSPACE}")
3131
echo "GitHub workspace '${GITHUB_WORKSPACE}' resolved to '${github_workspace_realpath}'"
3232

33+
# TODO(#1893): Consolidate directory traversal checks
3334
echo "Checking directory '${untrusted_realpath}' is a sub-directory of '${github_workspace_realpath}'"
3435
if [[ "${untrusted_realpath}" != "${github_workspace_realpath}" ]] && [[ ${untrusted_realpath} != ${github_workspace_realpath}/* ]]; then
3536
echo "${UNTRUSTED_DIRECTORY} not a sub-directory of ${GITHUB_WORKSPACE}"

0 commit comments

Comments
 (0)