Skip to content

Commit afa0f38

Browse files
fix: maven e2e: remove verify job (#3748)
# Summary Followup to #3746 Removes the verify job, which won't work, because the ref will be incorrect. - https://github.com/slsa-framework/slsa-github-generator/actions/runs/10115454784/job/27976327657#step:5:1 ``` WARNING: Insecure SLSA_VERIFIER_TESTING is enabled. Verifying artifact ./target/test-java-project-1.21.97.jar: FAILED: invalid ref: "refs/heads/main": unexpected ref type: "heads" FAILED: SLSA verification failed: invalid ref: "refs/heads/main": unexpected ref type: "heads" Error: Process completed with exit code 1. ``` ## Testing Process The e2e test is executed in this PR, which now passes. ## Checklist - [x] Review the contributing [guidelines](https://github.com/slsa-framework/slsa-github-generator/blob/main/CONTRIBUTING.md) - [x] Add a reference to related issues in the PR description. - [ ] Update documentation if applicable. - [x] Add unit tests if applicable. - [ ] Add changes to the [CHANGELOG](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md) if applicable. --------- Signed-off-by: Ramon Petgrave <[email protected]> Signed-off-by: Ramon Petgrave <[email protected]>
1 parent 6f49f01 commit afa0f38

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

.github/workflows/pre-submit.e2e.maven.yml

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -33,25 +33,3 @@ jobs:
3333
uses: slsa-framework/slsa-github-generator/.github/workflows/builder_maven_slsa3.yml@main
3434
with:
3535
directory: ./e2e/maven/workflow_dispatch
36-
37-
verify:
38-
runs-on: ubuntu-latest
39-
needs: [build]
40-
steps:
41-
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
42-
- uses: slsa-framework/slsa-github-generator/actions/maven/secure-download-attestations@main
43-
with:
44-
name: "${{ needs.build.outputs.provenance-download-name }}"
45-
sha256: "${{ needs.build.outputs.provenance-download-sha256 }}"
46-
path: ./
47-
- uses: slsa-framework/slsa-github-generator/actions/maven/secure-download-target@main
48-
with:
49-
name: "${{ needs.build.outputs.target-download-name }}"
50-
sha256: "${{ needs.build.outputs.target-download-sha256 }}"
51-
path: ./
52-
- uses: slsa-framework/slsa-verifier/actions/[email protected]
53-
- name: Verify artifact
54-
env:
55-
PROVENANCE_PATH: ${{ needs.build.outputs.provenance-download-name }}
56-
TARGET_PATH: ${{ needs.build.outputs.target-download-name }}
57-
run: slsa-verifier verify-artifact "$TARGET_PATH" --provenance-path "$PROVENANCE_PATH"

0 commit comments

Comments
 (0)