Fix bug where causing double commits (#281)

puerco · web-flow · commit b3836f8d777d · 2025-08-05T16:03:29.000-06:00
This commit fixes a bug where the pull request manager would
double commit when evaluating using git or the go implementation.

Signed-off-by: Adolfo García Veytia (Puerco) &lt;puerco@carabiner.dev&gt;
diff --git a/pkg/repo/clone.go b/pkg/repo/clone.go
@@ -168,6 +168,7 @@ func (c *Clone) Commit(opts *options.CommitOptions) error {
 			}
 			return err
 		}
+		return nil
 	}
 	return c.puregoCommit(opts)
 }
diff --git a/pkg/repo/pullrequest.go b/pkg/repo/pullrequest.go
@@ -107,7 +107,7 @@ func (prm *PullRequestManager) PullRequestFileList(
 	}
 
 	if err := prm.impl.CommitChanges(opts, clone); err != nil {
-		return nil, fmt.Errorf("committing changes to remote: %w", err)
+		return nil, fmt.Errorf("committing changes: %w", err)
 	}
 
 	if err := prm.impl.PushFeatureBranch(&prm.Options, clone); err != nil {

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,7 @@ func (c Clone) Commit(opts options.CommitOptions) error {`
`168`	`168`	`}`
`169`	`169`	`return err`
`170`	`170`	`}`
	`171`	`+ return nil`
`171`	`172`	`}`
`172`	`173`	`return c.puregoCommit(opts)`
`173`	`174`	`}`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ func (prm *PullRequestManager) PullRequestFileList(`
`107`	`107`	`}`
`108`	`108`
`109`	`109`	`if err := prm.impl.CommitChanges(opts, clone); err != nil {`
`110`		`- return nil, fmt.Errorf("committing changes to remote: %w", err)`
	`110`	`+ return nil, fmt.Errorf("committing changes: %w", err)`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`if err := prm.impl.PushFeatureBranch(&prm.Options, clone); err != nil {`