Skip to content

Fix panic building policy for repos without provenance #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomHennen merged 1 commit into from
May 22, 2025
Merged

Fix panic building policy for repos without provenance #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sourcetool/pkg/policy/policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,10 +181,18 @@ func CreateLocalPolicy(ctx context.Context, gh_connection *gh_control.GitHubConn
return "", fmt.Errorf("could not get provenance for latest commit: %w", err)
}

eligibleLevel, _ := computeEligibleSlsaLevel(provPred.Controls)
eligibleSince, err := computeEligibleSince(provPred.Controls, eligibleLevel)
if err != nil {
return "", fmt.Errorf("could not compute eligible since: %w", err)
// Default to SLSA1 since unset date
var eligibleSince = &time.Time{}
var eligibleLevel = slsa_types.SlsaSourceLevel1

// Unless there is previous provenance metadata, then we can compute
// a higher level
if provPred != nil {
eligibleLevel, _ = computeEligibleSlsaLevel(provPred.Controls)
eligibleSince, err = computeEligibleSince(provPred.Controls, eligibleLevel)
if err != nil {
return "", fmt.Errorf("could not compute eligible since: %w", err)
}
}

p := RepoPolicy{
Expand Down
Loading