Commit b85d572
Bland, Mike
package.json,bin/slush.js: Bump to liftoff 2.5.0
Fixes the "should fail when running a generator without slushfile" test
case.
As noted in the commit that updated runSlush() from test/slush.js and
caused the failure, slush was actually failing without the expected "No
slushfile found" message. It was failing with a stack trace that
started with:
path.js:39
throw new ERR_INVALID_ARG_TYPE('path', 'string', path);
^
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type
string. Received type object
at assertPath (path.js:39:11)
at Object.extname (path.js:1375:5)
at Liftoff.buildEnvironment (/Users/mbland/src/mbland/slush/node_modules/liftoff/index.js:111:50)
at Liftoff.launch (/Users/mbland/src/mbland/slush/node_modules/liftoff/index.js:154:22)
at Object.<anonymous> (/Users/mbland/src/mbland/slush/bin/slush.js:57:5)
This points to a bug in the previous version of liftoff whereby the the
search for `slushfile.js` found nothing, resulting in a `configPath` of
`null`. liftoff passed this `null` to `Object.extname`, resulting in
this stack trace.
liftoff v2.5.0 doesn't have this problem, but it does have a slightly
different API. With the changes to `bin/slush.js`, this test case now
passes along with the rest of the suite.1 parent d37ae3a commit b85d572
2 files changed
+7
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
19 | 20 | | |
20 | 21 | | |
21 | 22 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | 38 | | |
43 | 39 | | |
44 | 40 | | |
| |||
54 | 50 | | |
55 | 51 | | |
56 | 52 | | |
57 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
58 | 58 | | |
59 | 59 | | |
60 | | - | |
61 | | - | |
62 | 60 | | |
63 | | - | |
64 | 61 | | |
65 | 62 | | |
66 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | | - | |
| 31 | + | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
| |||
0 commit comments