settings [nfc]: Use update method directly on GlobalSettingsStore

This completes the transition to GlobalSettingsStore as the
self-contained store for the global settings.

Author: gnprice

lib/model/store.dart

@@ -86,12 +86,6 @@ abstract class GlobalStore extends ChangeNotifier {
   /// subscribes to changes in the [GlobalSettingsStore].
   final GlobalSettingsStore settings;
 
-  /// Update the global settings in the store.
-  // TODO inline this out
-  Future<void> updateGlobalSettings(GlobalSettingsCompanion data) async {
-    await settings.update(data);
-  }
-
   /// A cache of the [Accounts] table in the underlying data store.
   final Map<int, Account> _accounts;
 

lib/widgets/settings.dart

@@ -33,7 +33,8 @@ class _ThemeSetting extends StatelessWidget {
   const _ThemeSetting();
 
   void _handleChange(BuildContext context, ThemeSetting? newThemeSetting) {
-    GlobalStoreWidget.of(context).updateGlobalSettings(
+    final globalSettings = GlobalStoreWidget.settingsOf(context);
+    globalSettings.update(
       GlobalSettingsCompanion(themeSetting: Value(newThemeSetting)));
   }
 
@@ -60,10 +61,10 @@ class _BrowserPreferenceSetting extends StatelessWidget {
   const _BrowserPreferenceSetting();
 
   void _handleChange(BuildContext context, bool newOpenLinksWithInAppBrowser) {
-    GlobalStoreWidget.of(context).updateGlobalSettings(
-      GlobalSettingsCompanion(browserPreference: Value(
-        newOpenLinksWithInAppBrowser ? BrowserPreference.inApp
-                                     : BrowserPreference.external)));
+    final globalSettings = GlobalStoreWidget.settingsOf(context);
+    globalSettings.update(GlobalSettingsCompanion(browserPreference: Value(
+      newOpenLinksWithInAppBrowser ? BrowserPreference.inApp
+                                   : BrowserPreference.external)));
   }
 
   @override

test/model/store_test.dart

@@ -37,7 +37,7 @@ void main() {
       final globalStore = eg.globalStore();
       check(globalStore).settings.themeSetting.equals(null);
 
-      await globalStore.updateGlobalSettings(
+      await globalStore.settings.update(
         GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.dark)));
       check(globalStore).settings.themeSetting.equals(ThemeSetting.dark);
     });
@@ -48,7 +48,7 @@ void main() {
       globalStore.settings.addListener(() => notifyCount++);
       check(notifyCount).equals(0);
 
-      await globalStore.updateGlobalSettings(
+      await globalStore.settings.update(
         GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.light)));
       check(notifyCount).equals(1);
     });

test/widgets/content_test.dart

@@ -801,7 +801,7 @@ void main() {
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
     testWidgets('follow browser preference setting to open URL', (tester) async {
-      await testBinding.globalStore.updateGlobalSettings(
+      await testBinding.globalStore.settings.update(
         GlobalSettingsData(
           browserPreference: BrowserPreference.inApp).toCompanion(false));
       await prepare(tester,

test/widgets/settings_test.dart

@@ -51,7 +51,7 @@ void main() {
     testWidgets('smoke', (tester) async {
       debugBrightnessOverride = Brightness.light;
 
-      await testBinding.globalStore.updateGlobalSettings(
+      await testBinding.globalStore.settings.update(
         GlobalSettingsData(themeSetting: ThemeSetting.light).toCompanion(false));
       await prepare(tester);
       final element = tester.element(find.byType(SettingsPage));
@@ -101,7 +101,7 @@ void main() {
     }
 
     testWidgets('smoke', (tester) async {
-      await testBinding.globalStore.updateGlobalSettings(
+      await testBinding.globalStore.settings.update(
         GlobalSettingsData(
           browserPreference: BrowserPreference.external).toCompanion(false));
       await prepare(tester);

test/widgets/store_test.dart

@@ -106,7 +106,7 @@ void main() {
 
   testWidgets('GlobalStoreWidget.settingsOf updates on settings update', (tester) async {
     addTearDown(testBinding.reset);
-    await testBinding.globalStore.updateGlobalSettings(
+    await testBinding.globalStore.settings.update(
       GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.dark)));
 
     ThemeSetting? themeSetting;
@@ -120,7 +120,7 @@ void main() {
     await tester.pump();
     check(themeSetting).equals(ThemeSetting.dark);
 
-    await testBinding.globalStore.updateGlobalSettings(
+    await testBinding.globalStore.settings.update(
       GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.light)));
     await tester.pump();
     check(themeSetting).equals(ThemeSetting.light);

test/widgets/theme_test.dart

@@ -134,11 +134,11 @@ void main() {
     final element = tester.element(find.byType(Placeholder));
     check(zulipThemeData(element)).brightness.equals(Brightness.light);
 
-    await testBinding.globalStore.updateGlobalSettings(
+    await testBinding.globalStore.settings.update(
       const GlobalSettingsCompanion(themeSetting: Value(ThemeSetting.dark)));
     check(zulipThemeData(element)).brightness.equals(Brightness.dark);
 
-    await testBinding.globalStore.updateGlobalSettings(
+    await testBinding.globalStore.settings.update(
       const GlobalSettingsCompanion(themeSetting: Value(null)));
     check(zulipThemeData(element)).brightness.equals(Brightness.light);
   });