notif test: Decompose takeStartingRoutes

See discussion:
  zulip#1784 (comment)

Author: chrisbobbe

test/notifications/open_test.dart

@@ -85,22 +85,21 @@ void main() {
   group('NotificationOpenService', () {
     late List<Route<void>> pushedRoutes;
 
-    void takeStartingRoutes({Account? account, bool withAccount = true}) {
-      account ??= eg.selfAccount;
-      final expected = <Condition<Object?>>[
-        if (withAccount)
-          (it) => it.isA<MaterialAccountWidgetRoute>()
-            ..accountId.equals(account!.id)
-            ..page.isA<HomePage>()
-        else
-          (it) => it.isA<WidgetRoute>().page.isA<ChooseAccountPage>(),
-      ];
-      check(pushedRoutes.take(expected.length)).deepEquals(expected);
-      pushedRoutes.removeRange(0, expected.length);
+    void takeHomePageRouteForAccount(int accountId) {
+      check(pushedRoutes).first.which(
+        (it) => it.isA<MaterialAccountWidgetRoute>()
+          ..accountId.equals(accountId)
+          ..page.isA<HomePage>());
+      pushedRoutes.removeAt(0);
+    }
+
+    void takeChooseAccountPageRoute() {
+      check(pushedRoutes).first.which(
+        (it) => it.isA<WidgetRoute>().page.isA<ChooseAccountPage>());
+      pushedRoutes.removeAt(0);
     }
 
-    Future<void> prepare(WidgetTester tester,
-        {bool early = false, bool withAccount = true}) async {
+    Future<void> prepare(WidgetTester tester, {bool early = false}) async {
       await init();
       pushedRoutes = [];
       final testNavObserver = TestNavigatorObserver()
@@ -113,7 +112,13 @@ void main() {
         return;
       }
       await tester.pump();
-      takeStartingRoutes(withAccount: withAccount);
+      final accountIds = testBinding.globalStore.accountIds;
+      final initialAccountId = accountIds.firstOrNull;
+      if (initialAccountId == null) {
+        takeChooseAccountPageRoute();
+      } else {
+        takeHomePageRouteForAccount(initialAccountId);
+      }
       check(pushedRoutes).isEmpty();
     }
 
@@ -215,7 +220,9 @@ void main() {
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
     testWidgets('no accounts', (tester) async {
-      await prepare(tester, withAccount: false);
+      await prepare(tester);
+      // (just to make sure the test is working)
+      check(testBinding.globalStore.accountIds).isEmpty();
       await openNotification(tester, eg.selfAccount, eg.streamMessage());
       await tester.pump();
       check(pushedRoutes.single).isA<DialogRoute<void>>();
@@ -279,7 +286,7 @@ void main() {
       // Now let the GlobalStore get loaded and the app's main UI get mounted.
       await tester.pump();
       // The navigator first pushes the starting routes…
-      takeStartingRoutes();
+      takeHomePageRouteForAccount(eg.selfAccount.id); // because first in list
       // … and then the one the notification leads to.
       matchesNavigation(check(pushedRoutes).single, eg.selfAccount, message);
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
@@ -297,7 +304,7 @@ void main() {
 
       // Once the app is ready, we navigate to the conversation.
       await tester.pump();
-      takeStartingRoutes();
+      takeHomePageRouteForAccount(account.id); // because associated account
       matchesNavigation(check(pushedRoutes).single, account, message);
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
 
@@ -316,7 +323,7 @@ void main() {
       check(pushedRoutes).isEmpty(); // GlobalStore hasn't loaded yet
 
       await tester.pump();
-      takeStartingRoutes(account: accountB);
+      takeHomePageRouteForAccount(accountB.id); // because associated account
       matchesNavigation(check(pushedRoutes).single, accountB, message);
     }, variant: const TargetPlatformVariant({TargetPlatform.android, TargetPlatform.iOS}));
   });