Nit: Move unchecked suppression down to violating assignment in ParquetMetricsRowGroupFilter

Sreesh Maheshwar · Sreesh Maheshwar · commit 128a51c3824a · 2025-09-07T16:31:59.000+01:00
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java b/parquet/src/main/java/org/apache/iceberg/parquet/ParquetMetricsRowGroupFilter.java
@@ -437,7 +437,6 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
       int id = ref.fieldId();
 
@@ -447,6 +446,7 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
         return ROWS_CANNOT_MATCH;
       }
 
+      @SuppressWarnings("unchecked")
       Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
       if (colStats != null && !colStats.isEmpty()) {
         if (allNulls(colStats, valueCount)) {
@@ -486,7 +486,6 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {
     }
 
     @Override
-    @SuppressWarnings("unchecked")
     public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
       int id = ref.fieldId();
       Long valueCount = valueCounts.get(id);
@@ -496,6 +495,7 @@ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
         return ROWS_MIGHT_MATCH;
       }
 
+      @SuppressWarnings("unchecked")
       Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);
       if (colStats != null && !colStats.isEmpty()) {
         if (mayContainNull(colStats)) {

Original file line number	Diff line number	Diff line change
`@@ -437,7 +437,6 @@ public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {`
`437`	`437`	`}`
`438`	`438`
`439`	`439`	`@Override`
`440`		`- @SuppressWarnings("unchecked")`
`441`	`440`	`public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {`
`442`	`441`	`int id = ref.fieldId();`
`443`	`442`
`@@ -447,6 +446,7 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {`
`447`	`446`	`return ROWS_CANNOT_MATCH;`
`448`	`447`	`}`
`449`	`448`
	`449`	`+ @SuppressWarnings("unchecked")`
`450`	`450`	`Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);`
`451`	`451`	`if (colStats != null && !colStats.isEmpty()) {`
`452`	`452`	`if (allNulls(colStats, valueCount)) {`
`@@ -486,7 +486,6 @@ public <T> Boolean startsWith(BoundReference<T> ref, Literal<T> lit) {`
`486`	`486`	`}`
`487`	`487`
`488`	`488`	`@Override`
`489`		`- @SuppressWarnings("unchecked")`
`490`	`489`	`public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {`
`491`	`490`	`int id = ref.fieldId();`
`492`	`491`	`Long valueCount = valueCounts.get(id);`
`@@ -496,6 +495,7 @@ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {`
`496`	`495`	`return ROWS_MIGHT_MATCH;`
`497`	`496`	`}`
`498`	`497`
	`498`	`+ @SuppressWarnings("unchecked")`
`499`	`499`	`Statistics<Binary> colStats = (Statistics<Binary>) stats.get(id);`
`500`	`500`	`if (colStats != null && !colStats.isEmpty()) {`
`501`	`501`	`if (mayContainNull(colStats)) {`