tools improvements pack (#813)

* tools improvements pack

* diff in cloud

Author: mitya52

refact-agent/engine/src/cloud/messages_req.rs

@@ -289,10 +289,14 @@ pub fn convert_messages_to_thread_messages(
         } else if msg.role == "diff" {
             let extra_message = match serde_json::from_str::<Vec<DiffChunk>>(&msg.content.content_text_only()) {
                 Ok(chunks) => {
-                    chunks.iter()
-                        .filter(|x| !x.application_details.is_empty())
-                        .map(|x| x.application_details.clone())
-                        .join("\n")
+                    if chunks.is_empty() {
+                        "Nothing has changed.".to_string()
+                    } else {
+                        chunks.iter()
+                            .filter(|x| !x.application_details.is_empty())
+                            .map(|x| x.application_details.clone())
+                            .join("\n")
+                    }
                 },
                 Err(_) => "".to_string()
             };

refact-agent/engine/src/scratchpads/passthrough_convert_messages.rs

@@ -52,10 +52,14 @@ pub fn convert_messages_to_openai_format(messages: Vec<ChatMessage>, style: &Opt
         } else if msg.role == "diff" {
             let extra_message = match serde_json::from_str::<Vec<DiffChunk>>(&msg.content.content_text_only()) {
                 Ok(chunks) => {
-                    chunks.iter()
-                        .filter(|x| !x.application_details.is_empty())
-                        .map(|x| x.application_details.clone())
-                        .join("\n")
+                    if chunks.is_empty() {
+                        "Nothing has changed.".to_string()
+                    } else {
+                        chunks.iter()
+                            .filter(|x| !x.application_details.is_empty())
+                            .map(|x| x.application_details.clone())
+                            .join("\n")
+                    }
                 },
                 Err(_) => "".to_string()
             };

refact-agent/engine/src/tools/file_edit/auxiliary.rs

@@ -192,7 +192,7 @@ pub async fn str_replace(
     let occurrences = normalized_content.matches(&normalized_old_str).count();
     if occurrences == 0 {
         return Err(format!(
-            "No replacement was performed, `old_str` did not appear verbatim in {:?}. Consider checking the file content using `cat()`",
+            "No replacement was performed, `old_str` did not appear verbatim in {:?}. Check the file content using `cat()`",
             path
         ));
     }
@@ -232,7 +232,7 @@ pub async fn str_replace_regex(
     let occurrences = matches.len();
     if occurrences == 0 {
         return Err(format!(
-            "No replacement was performed, `pattern` did not appear verbatim in {:?}. Consider checking the file content using `cat()`",
+            "No replacement was performed, `pattern` did not appear verbatim in {:?}. Check the file content using `cat()`",
             path
         ));
     }

refact-agent/engine/src/tools/file_edit/tool_update_textdoc.rs

@@ -76,7 +76,7 @@ async fn parse_args(
             }
         },
         Some(v) => return Err(format!("Error: The 'multiple' argument must be a boolean (true/false) indicating whether to replace all occurrences, but received: {:?}", v)),
-        None => return Err("Error: The 'multiple' argument is required. Please specify true to replace all occurrences or false to replace only the first occurrence.".to_string())
+        None => false,
     };
 
     Ok(ToolUpdateTextDocArgs {
@@ -210,7 +210,7 @@ impl Tool for ToolUpdateTextDoc {
                     param_type: "boolean".to_string(),
                 }
             ],
-            parameters_required: vec!["path".to_string(), "old_str".to_string(), "replacement".to_string(), "multiple".to_string()],
+            parameters_required: vec!["path".to_string(), "old_str".to_string(), "replacement".to_string()],
         }
     }
 }

refact-agent/engine/src/tools/file_edit/tool_update_textdoc_regex.rs

@@ -84,7 +84,7 @@ async fn parse_args(
             }
         },
         Some(v) => return Err(format!("Error: The 'multiple' argument must be a boolean (true/false) indicating whether to replace all occurrences, but received: {:?}", v)),
-        None => return Err("Error: The 'multiple' argument is required. Please specify true to replace all occurrences or false to replace only the first occurrence.".to_string())
+        None => false,
     };
 
     Ok(ToolUpdateTextDocRegexArgs {
@@ -218,7 +218,7 @@ impl Tool for ToolUpdateTextDocRegex {
                     param_type: "boolean".to_string(),
                 }
             ],
-            parameters_required: vec!["path".to_string(), "pattern".to_string(), "replacement".to_string(), "multiple".to_string()],
+            parameters_required: vec!["path".to_string(), "pattern".to_string(), "replacement".to_string()],
         }
     }
 }

refact-agent/engine/src/tools/tool_regex_search.rs

@@ -158,7 +158,7 @@ async fn smart_compress_results(
     }
     if estimated_size > MAX_OUTPUT_SIZE {
         info!("Compressing `search_pattern` output: estimated {} bytes (exceeds 4KB limit)", estimated_size);
-        content.push_str("\nNote: Output has been compressed. Use more specific patterns or scopes for detailed results.");
+        content.push_str("\nNote: Output has been compressed. Use more specific pattern or scope for detailed results.");
     }
     content
 }
@@ -177,7 +177,7 @@ impl Tool for ToolRegexSearch {
             },
             agentic: false,
             experimental: false,
-            description: "Search for files and folders whose names or paths match the given regular expression pattern, and also search for text matches inside files using the same patterns. Reports both path matches and text matches in separate sections.".to_string(),
+            description: "Search for files and folders whose names or paths match the given regular expression pattern, and also search for text matches inside files using the same pattern. Reports both path matches and text matches in separate sections.".to_string(),
             parameters: vec![
                 ToolParam {
                     name: "pattern".to_string(),
@@ -282,7 +282,7 @@ impl Tool for ToolRegexSearch {
         }
 
         if all_search_results.is_empty() {
-            return Err("All pattern searches produced no results. Try adjusting your patterns or scope.".to_string());
+            return Err("All pattern searches produced no results. Try adjusting your pattern or scope.".to_string());
         }
 
         let mut results = vec_context_file_to_context_tools(all_search_results);