Skip to content

Commit 392fcdf

Browse files
authored
Merge pull request #2015 from jponge/kotlin/cleanups-nov-25
refactor: minor cleanups in the Kotlin module
2 parents 5b73fee + e728220 commit 392fcdf

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

kotlin/src/main/kotlin/io/smallrye/mutiny/coroutines/Multi.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,13 @@ import io.smallrye.mutiny.subscription.MultiSubscriber
66
import java.util.concurrent.Flow.Subscription
77
import java.util.concurrent.atomic.AtomicReference
88
import kotlin.coroutines.cancellation.CancellationException
9-
import kotlin.coroutines.coroutineContext
109
import kotlinx.coroutines.CoroutineScope
1110
import kotlinx.coroutines.cancel
1211
import kotlinx.coroutines.channels.BufferOverflow
1312
import kotlinx.coroutines.channels.Channel
1413
import kotlinx.coroutines.channels.awaitClose
1514
import kotlinx.coroutines.channels.trySendBlocking
15+
import kotlinx.coroutines.currentCoroutineContext
1616
import kotlinx.coroutines.flow.Flow
1717
import kotlinx.coroutines.flow.buffer
1818
import kotlinx.coroutines.flow.callbackFlow
@@ -32,7 +32,7 @@ import kotlinx.coroutines.launch
3232
fun <T> Multi<T>.asFlow(
3333
bufferCapacity: Int = Channel.UNLIMITED,
3434
bufferOverflowStrategy: BufferOverflow = BufferOverflow.SUSPEND
35-
): Flow<T> = callbackFlow<T> {
35+
): Flow<T> = callbackFlow {
3636
val parentCtx = coroutineContext
3737

3838
val subscriber = object : MultiSubscriber<T> {
@@ -77,7 +77,7 @@ fun <T> Multi<T>.asFlow(
7777
* without respecting the requested amount of the subscriber.
7878
*/
7979
suspend fun <T> Flow<T>.asMulti(): Multi<T> {
80-
val parentCtx = coroutineContext
80+
val parentCtx = currentCoroutineContext()
8181
return Multi.createFrom().emitter { em: MultiEmitter<in T> ->
8282
val job = CoroutineScope(parentCtx).launch {
8383
try {
@@ -101,4 +101,4 @@ suspend fun <T> Flow<T>.asMulti(): Multi<T> {
101101
}
102102
}
103103

104-
private class NonPropagatingCancellationException : kotlin.coroutines.cancellation.CancellationException()
104+
private class NonPropagatingCancellationException : CancellationException()

kotlin/src/main/kotlin/io/smallrye/mutiny/coroutines/Util.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,6 @@ import kotlinx.coroutines.CancellationException
99
internal inline fun suppressCancellationException(block: () -> Unit) =
1010
try {
1111
block()
12-
} catch (e: CancellationException) {
12+
} catch (_: CancellationException) {
1313
// CancellationExceptions are likely to happen if an emitter processes during cancellation/unsubscription.
1414
}

kotlin/src/test/kotlin/io/smallrye/mutiny/UniReplaceWithUnitTest.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ class UniReplaceWithUnitTest {
3535
@Test
3636
fun `test an Uni that's already Void`() {
3737
// Given
38-
val uni = Uni.createFrom().voidItem();
38+
val uni = Uni.createFrom().voidItem()
3939

4040
// When
4141
val subscriber = UniAssertSubscriber.create<Any>()

0 commit comments

Comments
 (0)