Why is MessageConverter cached?

[chriline]

Hi,

we're using MessageConverter to convert incoming messages to a custom object. Specifically we use canConvert to check the type of the message's payload. However we've found that the Converter is cached (see

smallrye-reactive-messaging/smallrye-reactive-messaging-provider/src/main/java/io/smallrye/reactive/messaging/providers/helpers/ConverterUtils.java

Lines 44 to 46 in bd75189

	if (actual != null) {
	// Use the cached converter.
	return actual.convert(o, injectedPayloadType);

), if canConvert returns true, and reused for different messages (

smallrye-reactive-messaging/smallrye-reactive-messaging-provider/src/main/java/io/smallrye/reactive/messaging/providers/helpers/ConverterUtils.java

Lines 53 to 59 in bd75189

	// Lookup and cache
	for (MessageConverter conv : getSortedInstances(converters)) {
	if (conv.canConvert(o, injectedPayloadType)) {
	actual = conv;
	return actual.convert(o, injectedPayloadType);
	}
	}

).

In our case canConvert returns true if the message's payload is of type byte-array and convert is called for subsequent messages where payload is null.

I was wondering why the message is presented to the canConvert method, if we may end up calling convert for different messages.