-
Notifications
You must be signed in to change notification settings - Fork 511
Update Debian version to trixie #2493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit updates the Debian version in the docker images from bookworm to trixie, the latest stable version.
Fixes @2469
This commit replaces the environment variables in CMD with the default files. This way we can run step-ca on the PID 1.
hslatman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing it to not use the environment variables could break existing deployments, although I doubt many would've changed the location of the password file. If we're OK with that, then I think the ENV declarations can be removed too?
|
|
||
| ENTRYPOINT ["/bin/bash", "/entrypoint.sh"] | ||
| CMD exec /usr/local/bin/step-ca --password-file $PWDPATH $CONFIGPATH | ||
| CMD ["/usr/local/bin/step-ca", "--password-file", "/home/step/secrets/password", "/home/step/config/ca.json"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It worked because of the exec, I suppose, as then it would run a shell? If you change the CMD to use e.g. ["sh", "-c", "step-ca ..."] they would get interpreted too, I believe, but then the CA runs as a subprocess.
One workaround could be to have step-ca read the password file flag value from the environment directly instead of from the flag? Basically what we do in other places supporting both environment variables and flags.
This commit updates the Debian version in the docker images from bookworm to trixie, the latest stable version.
Requires:
Fixes #2469, #2480
@hslatman @tashian: I wasn't sure how to avoid using the shell, without it the environment variables are not expanded. And if I use the old version, that will use a shell, the docker language server complains with:JSON arguments recommended for ENTRYPOINT/CMD to prevent unintended behavior related to OS signals (JSON arguments recommended for CMD to prevent unintended behavior related to OS signals)Docker DX (docker-language-server) JSONArgsRecommendedI've decided to hardcode the password and configuration path, so you can have step-ca running with the PID 1 with a command like this:
And k8s or docker allows you to change the CMD easily.