Merge pull request #109 from smallstep/herman/fix-load-vintage-defaults

Handle `LoadVintage` error when contexts are not in use

Author: hslatman

pkg/blackfriday/block.go

@@ -11,6 +11,7 @@
 // Functions to parse block-level elements.
 //
 
+//nolint:gocritic,revive,ineffassign,gosimple,wastedassign // ignore blackfriday
 package blackfriday
 
 import (

pkg/blackfriday/block_test.go

@@ -11,6 +11,7 @@
 // Unit tests for block parsing
 //
 
+//nolint:all
 package blackfriday
 
 import (

pkg/blackfriday/esc_test.go

@@ -1,3 +1,4 @@
+//nolint:all
 package blackfriday
 
 import (

pkg/blackfriday/helpers_test.go

@@ -11,6 +11,7 @@
 // Helper functions for unit testing
 //
 
+//nolint:all
 package blackfriday
 
 import (

pkg/blackfriday/html.go

@@ -13,6 +13,7 @@
 //
 //
 
+//nolint:gocritic,unused,revive // ignore blackfriday
 package blackfriday
 
 import (

pkg/blackfriday/inline.go

@@ -11,6 +11,7 @@
 // Functions to parse inline elements.
 //
 
+//nolint:gocritic,whitespace,wastedassign,revive // ignore blackfriday
 package blackfriday
 
 import (
@@ -721,7 +722,9 @@ func linkEndsWithEntity(data []byte, linkEnd int) bool {
 }
 
 // hasPrefixCaseInsensitive is a custom implementation of
-//     strings.HasPrefix(strings.ToLower(s), prefix)
+//
+//	strings.HasPrefix(strings.ToLower(s), prefix)
+//
 // we rolled our own because ToLower pulls in a huge machinery of lowercasing
 // anything from Unicode and that's very slow. Since this func will only be
 // used on ASCII protocol prefixes, we can take shortcuts.

pkg/blackfriday/inline_test.go

@@ -11,6 +11,7 @@
 // Unit tests for inline parsing
 //
 
+//nolint:all
 package blackfriday
 
 import (

pkg/blackfriday/markdown.go

@@ -5,6 +5,7 @@
 // Distributed under the Simplified BSD License.
 // See README.md for details.
 
+//nolint:gocritic,wastedassign,unused,revive,govet // ignore blackfriday
 package blackfriday
 
 import (
@@ -345,8 +346,8 @@ func WithNoExtensions() Option {
 // In Markdown, the link reference syntax can be made to resolve a link to
 // a reference instead of an inline URL, in one of the following ways:
 //
-//  * [link text][refid]
-//  * [refid][]
+//   - [link text][refid]
+//   - [refid][]
 //
 // Usually, the refid is defined at the bottom of the Markdown document. If
 // this override function is provided, the refid is passed to the override
@@ -363,21 +364,25 @@ func WithRefOverride(o ReferenceOverrideFunc) Option {
 // block of markdown-encoded text.
 //
 // The simplest invocation of Run takes one argument, input:
-//     output := Run(input)
+//
+//	output := Run(input)
+//
 // This will parse the input with CommonExtensions enabled and render it with
 // the default HTMLRenderer (with CommonHTMLFlags).
 //
 // Variadic arguments opts can customize the default behavior. Since Markdown
 // type does not contain exported fields, you can not use it directly. Instead,
 // use the With* functions. For example, this will call the most basic
 // functionality, with no extensions:
-//     output := Run(input, WithNoExtensions())
+//
+//	output := Run(input, WithNoExtensions())
 //
 // You can use any number of With* arguments, even contradicting ones. They
 // will be applied in order of appearance and the latter will override the
 // former:
-//     output := Run(input, WithNoExtensions(), WithExtensions(exts),
-//         WithRenderer(yourRenderer))
+//
+//	output := Run(input, WithNoExtensions(), WithExtensions(exts),
+//	    WithRenderer(yourRenderer))
 func Run(input []byte, opts ...Option) []byte {
 	r := NewHTMLRenderer(HTMLRendererParameters{
 		Flags: CommonHTMLFlags,
@@ -491,35 +496,35 @@ func (p *Markdown) parseRefsToAST() {
 //
 // Consider this markdown with reference-style links:
 //
-//     [link][ref]
+//	[link][ref]
 //
-//     [ref]: /url/ "tooltip title"
+//	[ref]: /url/ "tooltip title"
 //
 // It will be ultimately converted to this HTML:
 //
-//     <p><a href=\"/url/\" title=\"title\">link</a></p>
+//	<p><a href=\"/url/\" title=\"title\">link</a></p>
 //
 // And a reference structure will be populated as follows:
 //
-//     p.refs["ref"] = &reference{
-//         link: "/url/",
-//         title: "tooltip title",
-//     }
+//	p.refs["ref"] = &reference{
+//	    link: "/url/",
+//	    title: "tooltip title",
+//	}
 //
 // Alternatively, reference can contain information about a footnote. Consider
 // this markdown:
 //
-//     Text needing a footnote.[^a]
+//	Text needing a footnote.[^a]
 //
-//     [^a]: This is the note
+//	[^a]: This is the note
 //
 // A reference structure will be populated as follows:
 //
-//     p.refs["a"] = &reference{
-//         link: "a",
-//         title: "This is the note",
-//         noteID: <some positive int>,
-//     }
+//	p.refs["a"] = &reference{
+//	    link: "a",
+//	    title: "This is the note",
+//	    noteID: <some positive int>,
+//	}
 //
 // TODO: As you can see, it begs for splitting into two dedicated structures
 // for refs and for footnotes.

pkg/blackfriday/markdown_test.go

@@ -11,6 +11,7 @@
 // Unit tests for full document parsing and rendering
 //
 
+//nolint:all
 package blackfriday
 
 import "testing"

pkg/blackfriday/node.go

@@ -1,3 +1,4 @@
+//nolint:gocritic,unused // ignore blackfriday
 package blackfriday
 
 import (