Add tests for FirstStringOf

Author: dopey

flags/flags_test.go

@@ -230,3 +230,122 @@ func TestParseFingerprintFormat(t *testing.T) {
 		})
 	}
 }
+
+func TestFirstStringOf(t *testing.T) {
+	getAppSet := func() (*cli.App, *flag.FlagSet) {
+		app := &cli.App{}
+		set := flag.NewFlagSet("contrive", 0)
+		return app, set
+	}
+	tests := []struct {
+		name       string
+		getContext func() *cli.Context
+		inputs     []string
+		want       string
+	}{
+		{
+			name: "no-flags-empty",
+			getContext: func() *cli.Context {
+				app, set := getAppSet()
+				//_ = set.String("ca-url", "", "")
+				return cli.NewContext(app, set, nil)
+			},
+			inputs: []string{"foo", "bar"},
+			want:   "",
+		},
+		{
+			name: "return-first-set-flag",
+			getContext: func() *cli.Context {
+				app, set := getAppSet()
+				_ = set.String("foo", "", "")
+				_ = set.String("bar", "", "")
+				_ = set.String("baz", "", "")
+				ctx := cli.NewContext(app, set, nil)
+				ctx.Set("bar", "test1")
+				ctx.Set("baz", "test2")
+				return ctx
+			},
+			inputs: []string{"foo", "bar", "baz"},
+			want:   "test1",
+		},
+		{
+			name: "return-first-default-flag",
+			getContext: func() *cli.Context {
+				app, set := getAppSet()
+				_ = set.String("foo", "", "")
+				_ = set.String("bar", "", "")
+				_ = set.String("baz", "test1", "")
+				ctx := cli.NewContext(app, set, nil)
+				return ctx
+			},
+			inputs: []string{"foo", "bar", "baz"},
+			want:   "test1",
+		},
+		{
+			name: "all-empty",
+			getContext: func() *cli.Context {
+				app, set := getAppSet()
+				_ = set.String("foo", "", "")
+				_ = set.String("bar", "", "")
+				_ = set.String("baz", "", "")
+				ctx := cli.NewContext(app, set, nil)
+				return ctx
+			},
+			inputs: []string{"foo", "bar", "baz"},
+			want:   "",
+		},
+		/*
+			{
+				name:      "negative",
+				minLength: -5,
+				promptRun: promptRunner([]string{"foobar"}, nil),
+				want:      "foobar",
+				wantErr:   false,
+			},
+			{
+				name:      "zero",
+				minLength: 0,
+				promptRun: promptRunner([]string{"foobar"}, nil),
+				want:      "foobar",
+				wantErr:   false,
+			},
+			{
+				name:      "greater-than-min-length",
+				minLength: 5,
+				promptRun: promptRunner([]string{"foobar"}, nil),
+				want:      "foobar",
+				wantErr:   false,
+			},
+			{
+				name:      "equal-min-length",
+				minLength: 6,
+				promptRun: promptRunner([]string{"foobar"}, nil),
+				want:      "foobar",
+				wantErr:   false,
+			},
+			{
+				name:      "less-than-min-length",
+				minLength: 8,
+				promptRun: promptRunner([]string{"pass", "foobar", "password"}, nil),
+				want:      "password",
+				wantErr:   false,
+			},
+			{
+				name:      "ignore-post-whitespace-characters",
+				minLength: 7,
+				promptRun: promptRunner([]string{"pass   ", "foobar ", "password  "}, nil),
+				want:      "password",
+				wantErr:   false,
+			},
+		*/
+	}
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			ctx := tt.getContext()
+			val := FirstStringOf(ctx, tt.inputs...)
+			if val != tt.want {
+				t.Errorf("expected %v, but got %v", tt.want, val)
+			}
+		})
+	}
+}

utils/cautils/bootstrap.go

@@ -28,7 +28,7 @@ type bootstrapAPIResponse struct {
 	CaURL             string `json:"url"`
 	Fingerprint       string `json:"fingerprint"`
 	RedirectURL       string `json:"redirect-url"`
-	Provisioner       string `json:"issuer,omitempty"`
+	Provisioner       string `json:"provisioner,omitempty"`
 	MinPasswordLength int    `json:"min-password-length,omitempty"`
 }
 
@@ -61,9 +61,9 @@ type bootstrapContext struct {
 	minPasswordLength  int
 }
 
-func withProvisioner(issuer string) bootstrapOption {
+func withProvisioner(provisioner string) bootstrapOption {
 	return func(bc *bootstrapContext) {
-		bc.provisioner = issuer
+		bc.provisioner = provisioner
 	}
 }