addressed 2/3 deprecations

Author: k00ni

phpunit-windows.xml

@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!-- https://phpunit.de/manual/current/en/appendixes.configuration.html -->
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" backupGlobals="false" bootstrap="vendor\autoload.php" colors="true" processIsolation="false" stopOnFailure="false" cacheDirectory=".phpunit.cache" backupStaticProperties="false" displayDetailsOnTestsThatTriggerWarnings="true">
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" backupGlobals="false" bootstrap="vendor\autoload.php" colors="true" processIsolation="false" stopOnFailure="false" cacheDirectory=".phpunit.cache" backupStaticProperties="false" displayDetailsOnTestsThatTriggerWarnings="true" displayDetailsOnTestsThatTriggerDeprecations="true">
   <coverage>
     <include>
       <directory>src</directory>

src/Smalot/PdfParser/Document.php

@@ -299,7 +299,16 @@ public function extractXMPMetadata(string $content): void
                 $this->metadata = array_merge($this->metadata, $metadata);
             }
         }
-        xml_parser_free($xml);
+
+        // TODO: remove this if-clause and its content when dropping PHP 7 support
+        if (version_compare(PHP_VERSION, '8.0.0', '<')) {
+            // ref: https://www.php.net/manual/en/function.xml-parser-free.php
+            xml_parser_free($xml);
+
+            // to avoid memory leaks; documentation said:
+            // > it was necessary to also explicitly unset the reference to parser to avoid memory leaks
+            unset($xml);
+        }
     }
 
     public function getDictionary(): array

src/Smalot/PdfParser/RawData/FilterHelper.php

@@ -190,7 +190,10 @@ protected function decodeFilterASCII85Decode(string $data): string
                 // the value represented by a group of 5 characters should never be greater than 2^32 - 1
                 $tuple += (($char - 33) * $pow85[$group_pos]);
                 if (4 == $group_pos) {
-                    $decoded .= \chr($tuple >> 24).\chr($tuple >> 16).\chr($tuple >> 8).\chr($tuple);
+                    $decoded .= \chr($tuple >> 24)
+                        .\chr($tuple >> 16)
+                        .\chr($tuple >> 8)
+                        .\chr($tuple);
                     $tuple = 0;
                     $group_pos = 0;
                 } else {

tests/PHPUnit/Integration/PDFObjectTest.php

@@ -263,7 +263,14 @@ public function testFormatContent(): void
         $expected = str_replace(["\r\n", "\n"], ["\n", "\r\n"], $expected);
 
         $formatContent = new \ReflectionMethod('Smalot\PdfParser\PDFObject', 'formatContent');
-        $formatContent->setAccessible(true);
+
+        // TODO: remove this if-clause when dropping 8.0.x support
+        // From documentation > http://php.net/manual/en/reflectionproperty.setaccessible.php:
+        // As of PHP 8.1.0, calling this method has no effect; all properties are accessible by default.
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $formatContent->setAccessible(true);
+        }
+
         $cleaned = $formatContent->invoke($this->getPdfObjectInstance(new Document()), $content);
 
         $this->assertEquals($expected, $cleaned);
@@ -303,7 +310,13 @@ public function testFormatContent(): void
     public function testFormatContentIssue709()
     {
         $formatContent = new \ReflectionMethod('Smalot\PdfParser\PDFObject', 'formatContent');
-        $formatContent->setAccessible(true);
+
+        // TODO: remove this if-clause when dropping 8.0.x support
+        // From documentation > http://php.net/manual/en/reflectionproperty.setaccessible.php:
+        // As of PHP 8.1.0, calling this method has no effect; all properties are accessible by default.
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $formatContent->setAccessible(true);
+        }
 
         $content = '(String \\\\\\(string)Tj '.str_repeat('(Test)Tj ', 4500);
         $cleaned = $formatContent->invoke($this->getPdfObjectInstance(new Document()), $content);
@@ -319,7 +332,13 @@ public function testFormatContentIssue709()
     public function testFormatContentInlineImages(): void
     {
         $formatContent = new \ReflectionMethod('Smalot\PdfParser\PDFObject', 'formatContent');
-        $formatContent->setAccessible(true);
+
+        // TODO: remove this if-clause when dropping 8.0.x support
+        // From documentation > http://php.net/manual/en/reflectionproperty.setaccessible.php:
+        // As of PHP 8.1.0, calling this method has no effect; all properties are accessible by default.
+        if (version_compare(PHP_VERSION, '8.1.0', '<')) {
+            $formatContent->setAccessible(true);
+        }
 
         $cleaned = $formatContent->invoke(
             $this->getPdfObjectInstance(new Document()),