Add Jest-specific linting rules

Adding this caught a couple of important things:
- The sound integration tests have a `.only` in them
- The project-saver-hoc tests had two tests with the same description, causing possible confusion if that test broke

Author: rschamp

package-lock.json

@@ -56,6 +56,7 @@
     "eslint": "^5.0.1",
     "eslint-config-scratch": "^5.0.0",
     "eslint-plugin-import": "^2.8.0",
+    "eslint-plugin-jest": "^22.14.1",
     "eslint-plugin-react": "^7.12.4",
     "file-loader": "2.0.0",
     "get-float-time-domain-data": "0.1.0",

package.json

@@ -1,9 +1,10 @@
 module.exports = {
-    extends: ['scratch/react', 'scratch/es6'],
+    extends: ['scratch/react', 'scratch/es6', 'plugin:jest/recommended'],
     env: {
         browser: true,
         jest: true
     },
+    plugins: ['jest'],
     rules: {
         'react/prop-types': 0
     }

test/.eslintrc.js

@@ -1,4 +1,4 @@
-jasmine.DEFAULT_TIMEOUT_INTERVAL = 30000; // eslint-disable-line no-undef
+jest.setTimeout(30000); // eslint-disable-line no-undef
 
 import bindAll from 'lodash.bindall';
 import 'chromedriver'; // register path

test/helpers/selenium-helper.js

@@ -55,7 +55,7 @@ describe('Slider Prompt Container', () => {
         const componentProps = wrapper.find(SliderPromptComponent).props();
         componentProps.onChangeMin({target: {value: '1.0'}});
         componentProps.onOk();
-        expect(onOk).toBeCalledWith(1, 100, false);
+        expect(onOk).toHaveBeenCalledWith(1, 100, false);
     });
 
     test('Entering integers submits with isDiscrete=true', () => {
@@ -72,7 +72,7 @@ describe('Slider Prompt Container', () => {
         componentProps.onChangeMin({target: {value: '1'}});
         componentProps.onChangeMax({target: {value: '2'}});
         componentProps.onOk();
-        expect(onOk).toBeCalledWith(1, 2, true);
+        expect(onOk).toHaveBeenCalledWith(1, 2, true);
     });
 
     test('Enter button submits the form', () => {
@@ -89,7 +89,7 @@ describe('Slider Prompt Container', () => {
         componentProps.onChangeMin({target: {value: '1'}});
         componentProps.onChangeMax({target: {value: '2'}});
         componentProps.onKeyPress({key: 'Enter'});
-        expect(onOk).toBeCalledWith(1, 2, true);
+        expect(onOk).toHaveBeenCalledWith(1, 2, true);
     });
 
     test('Validates number-ness before submitting', () => {
@@ -105,7 +105,7 @@ describe('Slider Prompt Container', () => {
         const componentProps = wrapper.find(SliderPromptComponent).props();
         componentProps.onChangeMin({target: {value: 'hello'}});
         componentProps.onOk();
-        expect(onOk).not.toBeCalled();
-        expect(onCancel).toBeCalled();
+        expect(onOk).not.toHaveBeenCalled();
+        expect(onCancel).toHaveBeenCalled();
     });
 });

test/unit/containers/slider-prompt.test.jsx

@@ -18,33 +18,33 @@ describe('DragRecognizer', () => {
     test('start -> small drag', () => {
         dragRecognizer.start({clientX: 100, clientY: 100});
         window.dispatchEvent(new MouseEvent('mousemove', {clientX: 101, clientY: 101}));
-        expect(onDrag).not.toBeCalled();
+        expect(onDrag).not.toHaveBeenCalled();
     });
 
     test('start -> large vertical touch move -> scroll, not drag', () => {
         dragRecognizer.start({clientX: 100, clientY: 100});
         window.dispatchEvent(new MouseEvent('touchmove', {clientX: 106, clientY: 150}));
-        expect(onDrag).not.toBeCalled();
+        expect(onDrag).not.toHaveBeenCalled();
     });
 
     test('start -> large vertical mouse move -> mouse moves always drag)', () => {
         dragRecognizer.start({clientX: 100, clientY: 100});
         window.dispatchEvent(new MouseEvent('mousemove', {clientX: 100, clientY: 150}));
-        expect(onDrag).toBeCalled();
+        expect(onDrag).toHaveBeenCalled();
     });
 
     test('start -> large horizontal touch move -> drag', () => {
         dragRecognizer.start({clientX: 100, clientY: 100});
         window.dispatchEvent(new MouseEvent('touchmove', {clientX: 150, clientY: 106}));
-        expect(onDrag).toBeCalled();
+        expect(onDrag).toHaveBeenCalled();
     });
 
     test('after starting a scroll, it cannot become a drag', () => {
         dragRecognizer.start({clientX: 100, clientY: 100});
         window.dispatchEvent(new MouseEvent('touchmove', {clientX: 100, clientY: 110}));
         window.dispatchEvent(new MouseEvent('touchmove', {clientX: 100, clientY: 100}));
         window.dispatchEvent(new MouseEvent('touchmove', {clientX: 110, clientY: 100}));
-        expect(onDrag).not.toBeCalled();
+        expect(onDrag).not.toHaveBeenCalled();
     });
 
     test('start -> end unbinds', () => {

test/unit/util/drag-recognizer.test.js

@@ -423,7 +423,7 @@ describe('projectSaverHOC', () => {
         expect(mockedOnRemixing).toHaveBeenCalledWith(true);
     });
 
-    test('when starting to remix, onRemixing should be called with param true', () => {
+    test('when starting to remix, onRemixing should be called with param false', () => {
         const mockedOnRemixing = jest.fn();
         const mockedStoreProject = jest.fn(() => Promise.resolve());
         const Component = () => <div />;