Skip to content

Commit d3ab422

Browse files
nik9000smalyshev
authored andcommitted
ESQL: Mark csv-spec tests (elastic#132098)
Adds `csv-spec:` to the name of the test so our test triaging robot can understand when it sees failures of csv-spec tests. Looks like: ``` test {csv-spec:spatial.AirportsWithinPolygonCartesianDistanceFromCopenhagenTrainStation} ```
1 parent 26b6d95 commit d3ab422

File tree

4 files changed

+8
-12
lines changed

4 files changed

+8
-12
lines changed

muted-tests.yml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ tests:
290290
method: testOneRemoteClusterPartial
291291
issue: https://github.com/elastic/elasticsearch/issues/124055
292292
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
293-
method: test {lookup-join.MvJoinKeyOnTheLookupIndex ASYNC}
293+
method: test {csv-spec:lookup-join.MvJoinKeyOnTheLookupIndex}
294294
issue: https://github.com/elastic/elasticsearch/issues/128030
295295
- class: org.elasticsearch.packaging.test.EnrollmentProcessTests
296296
method: test20DockerAutoFormCluster
@@ -314,11 +314,8 @@ tests:
314314
method: testEarlyTermination
315315
issue: https://github.com/elastic/elasticsearch/issues/128721
316316
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT
317-
method: test {lookup-join.EnrichLookupStatsBug ASYNC}
317+
method: test {csv-spec:lookup-join.EnrichLookupStatsBug}
318318
issue: https://github.com/elastic/elasticsearch/issues/129228
319-
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT
320-
method: test {lookup-join.EnrichLookupStatsBug SYNC}
321-
issue: https://github.com/elastic/elasticsearch/issues/129229
322319
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeForkIT
323320
method: test {lookup-join.MultipleBatches*
324321
issue: https://github.com/elastic/elasticsearch/issues/129210
@@ -363,7 +360,7 @@ tests:
363360
method: testWriteCanRejectOnPrimaryBasedOnMaxOperationSize
364361
issue: https://github.com/elastic/elasticsearch/issues/130281
365362
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
366-
method: test {lookup-join.MvJoinKeyOnFrom SYNC}
363+
method: test {csv-spec:lookup-join.MvJoinKeyOnFrom}
367364
issue: https://github.com/elastic/elasticsearch/issues/130296
368365
- class: org.elasticsearch.xpack.esql.inference.bulk.BulkInferenceExecutorTests
369366
method: testSuccessfulExecution
@@ -378,7 +375,7 @@ tests:
378375
method: failed tasks output logged to console when spooling true
379376
issue: https://github.com/elastic/elasticsearch/issues/119509
380377
- class: org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT
381-
method: test {lookup-join.MvJoinKeyFromRow ASYNC}
378+
method: test {csv-spec:lookup-join.MvJoinKeyFromRow}
382379
issue: https://github.com/elastic/elasticsearch/issues/130642
383380
- class: org.elasticsearch.indices.stats.IndexStatsIT
384381
method: testFilterCacheStats
@@ -390,7 +387,7 @@ tests:
390387
method: testOpenContextsAfterRejections
391388
issue: https://github.com/elastic/elasticsearch/issues/130821
392389
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
393-
method: test {lookup-join.MvJoinKeyOnFromAfterStats ASYNC}
390+
method: test {csv-spec:lookup-join.MvJoinKeyOnFromAfterStats}
394391
issue: https://github.com/elastic/elasticsearch/issues/131148
395392
- class: org.elasticsearch.xpack.esql.ccq.MultiClustersIT
396393
method: testLookupJoinAliases
@@ -567,7 +564,6 @@ tests:
567564
# issue: "https://github.com/elastic/elasticsearch/..."
568565
# Note that this mutes for the unit-test-like CsvTests only.
569566
# Muting all the integration tests can be done using the class "org.elasticsearch.xpack.esql.**".
570-
# Consider however, that some tests are named as "test {file.test SYNC}" and "ASYNC" in the integration tests.
571567
# To mute all 3 tests safely everywhere use:
572568
# - class: "org.elasticsearch.xpack.esql.**"
573569
# method: "test {union_types.MultiIndexIpStringStatsInline}"

x-pack/plugin/esql/qa/server/multi-clusters/src/javaRestTest/java/org/elasticsearch/xpack/esql/ccq/MultiClusterSpecIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ public class MultiClusterSpecIT extends EsqlSpecTestCase {
8080
private static RestClient remoteClusterClient;
8181
private static DataLocation dataLocation = null;
8282

83-
@ParametersFactory(argumentFormatting = "%2$s.%3$s")
83+
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s")
8484
public static List<Object[]> readScriptSpec() throws Exception {
8585
List<URL> urls = classpathResources("/*.csv-spec");
8686
assertTrue("Not enough specs found " + urls, urls.size() > 0);

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/EsqlSpecTestCase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ public abstract class EsqlSpecTestCase extends ESRestTestCase {
9797
protected final Mode mode;
9898
protected static Boolean supportsTook;
9999

100-
@ParametersFactory(argumentFormatting = "%2$s.%3$s")
100+
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s")
101101
public static List<Object[]> readScriptSpec() throws Exception {
102102
List<URL> urls = classpathResources("/*.csv-spec");
103103
assertTrue("Not enough specs found " + urls, urls.size() > 0);

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/CsvTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ public class CsvTests extends ESTestCase {
193193
private ThreadPool threadPool;
194194
private Executor executor;
195195

196-
@ParametersFactory(argumentFormatting = "%2$s.%3$s")
196+
@ParametersFactory(argumentFormatting = "csv-spec:%2$s.%3$s")
197197
public static List<Object[]> readScriptSpec() throws Exception {
198198
List<URL> urls = classpathResources("/*.csv-spec");
199199
assertThat("Not enough specs found " + urls, urls, hasSize(greaterThan(0)));

0 commit comments

Comments
 (0)