[smarcet]

* bug fixing on multistatus response with one single
  element on collection

Author: smarcet

src/Facade/Responses/GenericMultiCalDAVResponse.php

@@ -25,8 +25,18 @@ class GenericMultiCalDAVResponse extends AbstractCalDAVResponse
 
     protected function parse()
     {
-        if(isset($this->content['response']) && !isset($this->content['response']['propstat']) && count($this->content['response'] > 0)){
-            foreach($this->content['response'] as $val){
+        if(isset($this->content['response'])){
+
+            if(isset($this->content['response']['propstat'])) {
+                // its a collection with one single element
+                $single_resource = $this->buildSingleResponse();
+                $single_resource->setContent(['response' => $this->content['response']]);
+                $single_resource->parse();
+                $this->responses[] = $single_resource;
+                return;
+            }
+
+            foreach ($this->content['response'] as $val) {
                 $single_resource = $this->buildSingleResponse();
                 $single_resource->setContent(['response' => $val]);
                 $single_resource->parse();

tests/FacadeTest.php

@@ -166,12 +166,10 @@ function testGetEventByUrl(){
     }
 
     function testGetEventsByUrl(){
-        $event_url  = '/8244464267/calendars/openstack-summit-sidney-2017/d7a2387264bfa1a619c37a593e94204a.ics';
-        $event_url2 = '/8244464267/calendars/openstack-summit-sidney-2017/8b91154e5cc76819a473de1a8652cc24.ics';
-
+        $event_url  = '/8244464267/calendars/openstack-summit-sidney-2017/0df083912b476631bf677c140ad4740b.ics';
 
         $res = self::$client->getEventsBy('https://p01-caldav.icloud.com:443/8244464267/calendars/openstack-summit-sidney-2017/',
-            [$event_url, $event_url2]);
+            [$event_url]);
 
         $this->assertTrue($res->isSuccessFull());
     }