Flake8 once again.

Author: Sylvain MARIE

pyfields/autofields_.py

@@ -258,28 +258,28 @@ def is_reserved_dunder(name):
 
 
 def autoclass(
-        # --- autofields
-        fields=True,                  # type: Union[bool, DecoratedClass]
-        typecheck=False,              # type: bool
-        # --- constructor
-        init=True,                    # type: bool
-        # --- class methods
-        dict=True,                    # type: bool
-        dict_public_only=True,        # type: bool
-        repr=True,                    # type: bool
-        repr_curly_mode=False,        # type: bool
-        repr_public_only=True,        # type: bool
-        eq=True,                      # type: bool
-        eq_public_only=False,         # type: bool
-        hash=True,                    # type: bool
-        hash_public_only=False,       # type: bool
-        # --- advanced
-        af_include_upper=False,       # type: bool
-        af_include_dunder=False,      # type: bool
-        af_exclude=DEFAULT_EXCLUDED,  # type: Iterable[str]
-        ac_include=None,              # type: Union[str, Tuple[str]]
-        ac_exclude=None,              # type: Union[str, Tuple[str]]
-    ):
+    # --- autofields
+    fields=True,                  # type: Union[bool, DecoratedClass]
+    typecheck=False,              # type: bool
+    # --- constructor
+    init=True,                    # type: bool
+    # --- class methods
+    dict=True,                    # type: bool
+    dict_public_only=True,        # type: bool
+    repr=True,                    # type: bool
+    repr_curly_mode=False,        # type: bool
+    repr_public_only=True,        # type: bool
+    eq=True,                      # type: bool
+    eq_public_only=False,         # type: bool
+    hash=True,                    # type: bool
+    hash_public_only=False,       # type: bool
+    # --- advanced
+    af_include_upper=False,       # type: bool
+    af_include_dunder=False,      # type: bool
+    af_exclude=DEFAULT_EXCLUDED,  # type: Iterable[str]
+    ac_include=None,              # type: Union[str, Tuple[str]]
+    ac_exclude=None,              # type: Union[str, Tuple[str]]
+):
     """
     A decorator to automate many things at once for your class.
 
@@ -407,7 +407,7 @@ def from_dict(cls, dct):
                 def __repr__(self):
                     """ Generated by @pyfields.autoclass based on the class fields """
                     return '%s(%s)' % (self.__class__.__name__,
-                                       ', '.join('%s=%r' % (k, getattr(self, k))  for k in repr_names))
+                                       ', '.join('%s=%r' % (k, getattr(self, k)) for k in repr_names))
             else:
                 def __repr__(self):
                     """ Generated by @pyfields.autoclass based on the class fields """
@@ -422,6 +422,7 @@ def __repr__(self):
         # __eq__
         if eq:
             eq_names = public_selected_names if eq_public_only else selected_names
+
             def __eq__(self, other):
                 """ Generated by @pyfields.autoclass based on the class fields """
                 if isinstance(other, dict):
@@ -532,8 +533,8 @@ def filter_names(all_names,
 #                          ):
 #     # type: (...) -> bool
 #     """
-#     Returns True if method `method_name` is already implemented by object_type, that is, its implementation differs from
-#     the one in `object`.
+#     Returns True if method `method_name` is already implemented by object_type, that is, its implementation differs
+#     from the one in `object`.
 #
 #     :param cls:
 #     :param method_name:

pyfields/core.py

@@ -9,7 +9,7 @@
 
 try:
     from inspect import signature, Parameter
-except ImportError:
+except ImportError:  # noqa
     # noinspection PyUnresolvedReferences,PyPackageRequirements
     from funcsigs import signature, Parameter
 
@@ -20,7 +20,7 @@
 
 try:  # python 3.5+
     # noinspection PyUnresolvedReferences
-    from typing import List, Callable, Type, Any, Union, Iterable, Tuple, TypeVar
+    from typing import Callable, Type, Any, Union, Iterable, Tuple, TypeVar
     _NoneType = type(None)
     use_type_hints = sys.version_info > (3, 0)
     if use_type_hints:
@@ -708,7 +708,7 @@ def field(type_hint=None,        # type: Union[Type[T], Iterable[Type[T]]]
 
      - @lazy_attribute (sagemath)
      - @cached_property (werkzeug) and https://stackoverflow.com/questions/24704147/python-what-is-a-lazy-property
-     - https://stackoverflow.com/questions/42023852/how-can-i-get-the-attribute-name-when-working-with-descriptor-protocol-in-python
+     - https://stackoverflow.com/q/42023852/7262247
      - attrs / dataclasses
 
     :param type_hint: an optional explicit type hint for the field, to override the type hint defined by PEP484
@@ -718,8 +718,8 @@ def field(type_hint=None,        # type: Union[Type[T], Iterable[Type[T]]]
     :param nonable: a boolean that can be used to explicitly declare that a field can contain `None`. When this is set
         to an explicit `True` or `False` value, usual type checking and validation (*if any*) are not anymore executed
         on `None` values. Instead ; if this is `True`, type checking and validation will be *deactivated* when the field
-        is set to `None` so as to always accept the value. If this is `False`, an `None`error will be raised when `None` is
-        set on the field.
+        is set to `None` so as to always accept the value. If this is `False`, an `None`error will be raised when `None`
+        is set on the field.
         When this is left as `GUESS` (default), the behaviour is "automatic". This means that
          - if the field (a) is optional with default value `None` or (b) has type hint `typing.Optional[]`, the
            behaviour will be the same as with `nonable=True`.
@@ -1082,15 +1082,15 @@ def __set__(self,
                 try:
                     # does the converter accept this input ?
                     accepted = converter.accepts(obj, self, value)
-                except Exception:
+                except Exception:  # noqa
                     # ignore all exceptions from converters
                     continue
                 else:
                     if accepted is None or accepted:
                         # if so, let's try to convert
                         try:
                             converted_value = converter.convert(obj, self, value)
-                        except Exception:
+                        except Exception:  # noqa
                             # ignore all exceptions from converters
                             continue
                         else:

pyfields/init_makers.py

@@ -13,8 +13,7 @@
 
 
 try:  # python 3.5+
-    from typing import Optional, Set, List, Callable, Dict, Type, Any, TypeVar, Union, Iterable, Tuple, Mapping
-    from valid8.common_syntax import ValidationFuncs
+    from typing import List, Callable, Any, Union, Iterable, Tuple
     use_type_hints = sys.version_info > (3, 0)
 except ImportError:
     use_type_hints = False
@@ -330,7 +329,8 @@ def __get__(self, obj, objtype):
                                user_init_fun=self.user_init_fun, user_init_args_before=self.user_init_args_before)
 
         # replace it forever in the class
-        setattr(objtype, '__init__', new_init)
+        # setattr(objtype, '__init__', new_init)
+        objtype.__init__ = new_init
 
         # return the new init
         return new_init.__get__(obj, objtype)

pyfields/validate_n_convert.py

@@ -16,7 +16,7 @@
 try:  # python 3.5+
     # noinspection PyUnresolvedReferences
     from typing import Callable, Type, Any, TypeVar, Union, Iterable, Tuple, Mapping, Optional, Dict, Literal
-    from valid8.common_syntax import ValidationFuncs
+    # from valid8.common_syntax import ValidationFuncs
     use_type_hints = sys.version_info > (3, 0)
 except ImportError:
     use_type_hints = False

setup.cfg

@@ -129,7 +129,7 @@ exclude_lines =
 max-line-length = 120
 extend-ignore = D, E203  # D: Docstring errors, E203: see https://github.com/PyCQA/pycodestyle/issues/373
 copyright-check = True
-copyright-regexp = ^\#\s+Authors:\s+Sylvain MARIE <sylvain\.marie@se\.com>\n\#\s+\+\sAll\scontributors\sto\s<https://github\.com/smarie/python\-makefun>\n\#\n\#\s+License:\s3\-clause\sBSD,\s<https://github\.com/smarie/python\-pyfields/blob/master/LICENSE>
+copyright-regexp = ^\#\s+Authors:\s+Sylvain MARIE <sylvain\.marie@se\.com>\n\#\s+\+\sAll\scontributors\sto\s<https://github\.com/smarie/python\-pyfields>\n\#\n\#\s+License:\s3\-clause\sBSD,\s<https://github\.com/smarie/python\-pyfields/blob/master/LICENSE>
 exclude =
     .git
     .github