Fixed ValueError issue happening with indirectly parametrized fixtures. Fixed #64

Author: Sylvain MARIE

pytest_cases/plugin.py

@@ -510,9 +510,10 @@ def getfixtureclosure(fm, fixturenames, parentnode, ignore_args=()):
 
         sorted_fixturenames = sort_according_to_ref_list(fixturenames, param_names)
         # **********
+        # merge the fixture names in correct order into the _init_fixnames
         merge(sorted_fixturenames, _init_fixnames)
     else:
-        # we cannot sort yet
+        # we cannot sort yet - merge the fixture names into the _init_fixnames
         merge(fixturenames, _init_fixnames)
         sorted_fixturenames = []
 
@@ -976,7 +977,12 @@ def sort_according_to_ref_list(fixturenames, param_names):
     """
     cur_indices = []
     for pname in param_names:
-        cur_indices.append(fixturenames.index(pname))
+        try:
+            cur_indices.append(fixturenames.index(pname))
+        except (ValueError, IndexError):
+            # can happen in case of indirect parametrization: a parameter is not in the fixture name.
+            # TODO we should maybe rather add the pname to fixturenames in this case ?
+            pass
     target_indices = sorted(cur_indices)
     sorted_fixturenames = list(fixturenames)
     for old_i, new_i in zip(cur_indices, target_indices):

pytest_cases/tests/issues/test_issue_indirect_fixture_param.py

@@ -0,0 +1,17 @@
+import pytest
+
+
+@pytest.fixture
+def my_fixture(request):
+    return request.param
+
+
+@pytest.fixture
+def dependent_fixture(my_fixture):
+    return my_fixture * 2
+
+
+@pytest.mark.parametrize('my_fixture', [123], indirect=True)
+def test_x(dependent_fixture):
+    assert dependent_fixture == 2 * 123
+