Fixed TypeError: got an unexpected keyword argument 'indirect' with pytest 5+. Fixed #70

Author: Sylvain MARIE

pytest_cases/common.py

@@ -91,6 +91,10 @@ class _ParametrizationMark:
 
     def __init__(self, mark):
         bound = get_parametrize_signature().bind(*mark.args, **mark.kwargs)
+        remaining_kwargs = bound.arguments['kwargs']
+        if len(remaining_kwargs) > 0:
+            warn("parametrize kwargs not taken into account: %s. Please report it at"
+                 " https://github.com/smarie/python-pytest-cases/issues" % remaining_kwargs)
         self.param_names = get_param_argnames_as_list(bound.arguments['argnames'])
         self.param_values = bound.arguments['argvalues']
         try:
@@ -197,7 +201,7 @@ def get_pytest_parametrize_marks(f):
             return ()
 
 
-def _pytest_mark_parametrize(argnames, argvalues, ids=None):
+def _pytest_mark_parametrize(argnames, argvalues, ids=None, indirect=False, scope=None, **kwargs):
     """ Fake method to have a reference signature of pytest.mark.parametrize"""
     pass
 

pytest_cases/tests/issues/test_issue_pytest_70.py

@@ -0,0 +1,23 @@
+import pytest
+from pytest_cases import fixture_ref, pytest_parametrize_plus, pytest_fixture_plus
+
+
+@pytest_fixture_plus
+@pytest_parametrize_plus("variant", ['A', 'B'])
+def book1(variant):
+    return variant
+
+
+@pytest.fixture
+def book2():
+    return
+
+
+@pytest_parametrize_plus("name", [
+    fixture_ref(book1),
+    'hi',
+    'ih',
+    fixture_ref(book2),
+])
+def test_get_or_create_book(name):
+    print(name)