Fixed "Created fixture names are not unique, please report" error when duplicate fixture reference is provided in a pytest.param. Fixes #138

Author: Sylvain MARIE

pytest_cases/fixture_parametrize_plus.py

@@ -26,7 +26,7 @@
 from .common_pytest_marks import has_pytest_param, get_param_argnames_as_list
 from .common_pytest_lazy_values import is_lazy_value, is_lazy, get_lazy_args
 from .common_pytest import get_fixture_name, remove_duplicates, mini_idvalset, is_marked_parameter_value, \
-    extract_parameterset_info, ParameterSet, cart_product_pytest, mini_idval, inject_host
+    extract_parameterset_info, ParameterSet, cart_product_pytest, mini_idval, inject_host, get_marked_parameter_values
 
 from .fixture__creation import check_name_available, CHANGE, WARN
 from .fixture_core1_unions import InvalidParamsList, NOT_USED, UnionFixtureAlternative, _make_fixture_union, \
@@ -698,6 +698,10 @@ def parametrize_plus_decorate(test_func, fixtures_dest):
                     fix_alt_names.append(a)
                 else:
                     # this should only happen when the alternative is directly a fixture reference
+                    if is_marked_parameter_value(alt):
+                        alt = get_marked_parameter_values(alt)
+                        assert len(alt) == 1, "Error with fixture reference, please report"
+                        alt = alt[0]
                     assert isinstance(alt, FixtureParamAlternative), \
                         "Created fixture names are not unique, please report"
 

pytest_cases/tests/pytest_extension/issues/test_issue_138.py

@@ -0,0 +1,25 @@
+import pytest
+from pytest_cases import fixture, parametrize, fixture_ref
+
+
+@fixture
+def b():
+    print("b")
+    return "b"
+
+
+@parametrize("fixture", [fixture_ref(b),
+                         pytest.param(fixture_ref(b))
+                         ])
+def test(fixture):
+    assert fixture == "b"
+    print("Test ran fixure %s" % fixture)
+
+
+@parametrize("fixture,a", [(fixture_ref(b), 1),
+                           pytest.param(fixture_ref(b), 1)
+                           ])
+def test2(fixture, a):
+    assert fixture == "b"
+    assert a == 1
+    print("Test ran fixure %s" % fixture)