Skip to content

Commit 584a51f

Browse files
smarieSylvain MARIE
andauthored
get_all_cases : fixed default value for cases (#291)
* Fixed issue with `get_all_cases`: default value for `cases` was wrong. Fixes #290 * changelog --------- Co-authored-by: Sylvain MARIE <[email protected]>
1 parent cbe663d commit 584a51f

File tree

3 files changed

+12
-4
lines changed

3 files changed

+12
-4
lines changed

docs/changelog.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
### 3.6.14 - bugfix
4+
5+
- Fixed issue with `get_all_cases`: default value for `cases` was wrong. Fixes [#290](https://github.com/smarie/python-pytest-cases/issues/290)
6+
37
### 3.6.13 - bugfix
48

59
- Fixed issue where a lazy value (for example a case function) was not resolved before being injected in a parametrized function, and was therefore appearing as a `_LazyValueCaseParamValue `. Fixed [#274](https://github.com/smarie/python-pytest-cases/issues/274)

src/pytest_cases/case_parametrizer_new.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ def _glob_name_filter(case_fun):
207207

208208

209209
def get_all_cases(parametrization_target=None, # type: Callable
210-
cases=None, # type: Union[CaseType, List[CaseType]]
210+
cases=AUTO, # type: Union[CaseType, List[CaseType]]
211211
prefix=CASE_PREFIX_FUN, # type: str
212212
glob=None, # type: str
213213
has_tag=None, # type: Union[str, Iterable[str]]
@@ -675,7 +675,7 @@ def import_default_cases_module(test_module_name):
675675
# Nothing worked
676676
raise ValueError("Error importing test cases module to parametrize %r: unable to import AUTO "
677677
"cases module %r nor %r. Maybe you wish to import cases from somewhere else ? In that case"
678-
"please specify `cases=...`."
678+
" please specify `cases=...`."
679679
% (test_module_name, cases_module_name1, cases_module_name2))
680680

681681
return cases_module

tests/cases/issues/issue_258/test_issue_258.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,12 @@ def test_relative_module_cases():
6262
assert {"hello .", "hi ."} == {f() for f in relative_import_cases}
6363

6464

65-
def test_auto_cases():
66-
auto_import_cases = get_all_cases(cases=AUTO)
65+
@parametrize("explicit", (True, False))
66+
def test_auto_cases(explicit):
67+
if explicit:
68+
auto_import_cases = get_all_cases(cases=AUTO)
69+
else:
70+
auto_import_cases = get_all_cases()
6771
assert {"hello AUTO", "hi AUTO"} == {f() for f in auto_import_cases}
6872

6973

0 commit comments

Comments
 (0)