Fixed issue with Empty id marker leaking to test ids. Fixed #171

Author: Sylvain MARIE

pytest_cases/fixture_parametrize_plus.py

@@ -531,7 +531,7 @@ def get_alternative_id(self):
 
     def remove_empty_ids(callspec):
         # used by plugin.py to remove the EMPTY_ID from the callspecs
-        callspec._idlist = [c for c in callspec._idlist if c != EMPTY_ID]
+        callspec._idlist = [c for c in callspec._idlist if not c.startswith(EMPTY_ID)]
 
 elif PYTEST421_OR_GREATER:
     # an empty string will be taken into account and filtered out in CallSpec2.id.

pytest_cases/tests/cases/issues/test_issue_171.py

@@ -0,0 +1,95 @@
+import pytest
+from pytest_cases import case, parametrize_with_cases
+
+
+class CreateCases(object):
+    @case(id="current_object")
+    def case_create_1(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="lala")
+    def case_create_10(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="without_validation")
+    @pytest.mark.usefixtures("validationOff")
+    def case_create_2(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="history_object")
+    def case_create_3(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="xml_with_namespaces")
+    def case_create_4(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="duplicate_name")
+    def case_create_6(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="duplicate_name_without_valid")
+    @pytest.mark.usefixtures("validationOff")
+    def case_create_61(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="not_enough_namespaceses")
+    def case_create_7(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+
+    @case(id="invalid_xml")
+    def case_create_8(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+    @case(id="invalid_xml_without_valid")
+    @pytest.mark.usefixtures("validationOff")
+    def case_create_9(self):
+        inputs = ["foo", "bar"]
+        request_data = {"foo": "dfg", "data": "asd"}
+        return inputs, request_data
+
+
+@pytest.fixture
+def validationOff():
+    # app.config["validation"] = False
+    yield
+    # app.config["validation"] = True
+
+
+@parametrize_with_cases("inputs,request_data", cases=".", prefix="case_create_")
+def test_create(inputs, request_data):
+    pass
+
+
+def test_synthesis(module_results_dct):
+    assert list(module_results_dct) == [
+         'test_create[current_object]',
+         'test_create[lala]',
+         'test_create[without_validation]',
+         'test_create[history_object]',
+         'test_create[xml_with_namespaces]',
+         'test_create[duplicate_name]',
+         'test_create[duplicate_name_without_valid]',
+         'test_create[not_enough_namespaceses]',
+         'test_create[invalid_xml]',
+         'test_create[invalid_xml_without_valid]'
+    ]