Case functions that are staticmethod and classmethod are now supported as well. Fixes #168

Author: Sylvain MARIE

pytest_cases/case_parametrizer_new.py

@@ -675,20 +675,21 @@ def _of_interest(x):  # noqa
             co_firstlineno = get_code_first_line(m)
             if cls is not None:
                 if isinstance(cls.__dict__[m_name], (staticmethod, classmethod)):
-                    # skip it
-                    continue
-                # partialize the function to get one without the 'self' argument
-                new_m = functools.partial(m, cls())
-                # remember the class
-                setattr(new_m, _HOST_CLS_ATTR, cls)
-                # we have to recopy all metadata concerning the case function
-                new_m.__name__ = m.__name__
-                copy_case_info(m, new_m)
-                copy_pytest_marks(m, new_m, override=True)
-                # also recopy all marks from the holding class to the function
-                copy_pytest_marks(cls, new_m, override=False)
-                m = new_m
-                del new_m
+                    # nothing to do: no need to partialize a 'self' argument
+                    pass
+                else:
+                    # partialize the function to get one without the 'self' argument
+                    new_m = functools.partial(m, cls())
+                    # remember the class
+                    setattr(new_m, _HOST_CLS_ATTR, cls)
+                    # we have to recopy all metadata concerning the case function
+                    new_m.__name__ = m.__name__
+                    copy_case_info(m, new_m)
+                    copy_pytest_marks(m, new_m, override=True)
+                    # also recopy all marks from the holding class to the function
+                    copy_pytest_marks(cls, new_m, override=False)
+                    m = new_m
+                    del new_m
 
             if _case_param_factory is None:
                 # Nominal usage: put the case in the dictionary

pytest_cases/tests/cases/issues/test_issue_168.py

@@ -0,0 +1,42 @@
+import pytest
+
+from pytest_cases import parametrize_with_cases, case, parametrize
+
+
+class FooCases:
+    @staticmethod
+    def case_static():
+        return 1
+
+    @classmethod
+    def case_class(cls):
+        return 1
+
+    @staticmethod
+    @case(id="foo")
+    def case_static_custom_id():
+        return 1
+
+    @staticmethod
+    @pytest.mark.skip
+    def case_static_skipped():
+        assert False, "should be skipped"
+
+    @classmethod
+    @parametrize("o", [1])
+    def case_class_fix(cls, o):
+        return o
+
+
+@parametrize_with_cases("a", cases='.')
+def test_foo(a):
+    assert a == 1
+
+
+def test_synthesis(module_results_dct):
+    assert list(module_results_dct) == [
+        'test_foo[static]',
+        'test_foo[class]',
+        'test_foo[foo]',
+        'test_foo[class_fix-1]'
+    ]