Skip to content

Commit da5cceb

Browse files
committed
Fixed incorrect versions returned by the adapters
1 parent f61b57c commit da5cceb

File tree

2 files changed

+28
-15
lines changed

2 files changed

+28
-15
lines changed

displaysdk7/SASGMAUtils.swift

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ class SASGMAAdNetworkExtras: NSObject, GADAdNetworkExtras {
2222
class SASGMAUtils {
2323

2424
static let SASImplementationInfo_PrimarySDKName = "GoogleMobileAds"
25-
static let SASImplementationInfo_MediationAdapterVersion = "1.1.0"
25+
static let SASImplementationInfo_MediationAdapterVersion_Major = 1
26+
static let SASImplementationInfo_MediationAdapterVersion_Minor = 1
27+
static let SASImplementationInfo_MediationAdapterVersion_Patch = 0
28+
static let adaptersVersionString = "\(SASImplementationInfo_MediationAdapterVersion_Major).\(SASImplementationInfo_MediationAdapterVersion_Minor).\(SASImplementationInfo_MediationAdapterVersion_Patch)"
2629

2730
static private let customEventServerSeparatorString = "/"
2831

@@ -32,15 +35,18 @@ class SASGMAUtils {
3235
static let kSASGMAErrorCodeFailToLoadNativeAd = 102
3336

3437
static func adapterVersion() -> GADVersionNumber {
35-
return GADVersionNumber.init(majorVersion: 3, minorVersion: 0, patchVersion: 0)
38+
return GADVersionNumber.init(majorVersion: SASImplementationInfo_MediationAdapterVersion_Major,
39+
minorVersion: SASImplementationInfo_MediationAdapterVersion_Minor,
40+
patchVersion: SASImplementationInfo_MediationAdapterVersion_Patch)
3641
}
3742

3843
static func adSDKVersion() -> GADVersionNumber {
3944
let versions = SASFrameworkInfo.shared.frameworkVersionString.components(separatedBy: ".")
40-
guard versions.count == 3 else {
41-
return GADVersionNumber.init(majorVersion: 7, minorVersion: 0, patchVersion: 0)
42-
}
43-
return GADVersionNumber.init(majorVersion: Int(versions[0]) ?? 7, minorVersion: Int(versions[1]) ?? 0, patchVersion: Int(versions[2]) ?? 0)
45+
let majorVersion = versions.indices.contains(0) ? Int(versions[0]) ?? 0 : 0
46+
let minorVersion = versions.indices.contains(1) ? Int(versions[1]) ?? 0 : 0
47+
let patchVersion = versions.indices.contains(2) ? Int(versions[2]) ?? 0 : 0
48+
49+
return GADVersionNumber.init(majorVersion: majorVersion, minorVersion: minorVersion, patchVersion: patchVersion)
4450
}
4551

4652
static func placementWith(adConfiguration: GADMediationAdConfiguration) -> SASAdPlacement? {
@@ -86,7 +92,7 @@ class SASGMAUtils {
8692
SASConfiguration.shared.configure(siteId: siteId)
8793
SASConfiguration.shared.secondaryImplementationInfo = SASSecondaryImplementationInfo(primarySDKName: SASImplementationInfo_PrimarySDKName,
8894
primarySDKVersion: GADGetStringFromVersionNumber(GADMobileAds.sharedInstance().versionNumber),
89-
mediationAdapterVersion: SASImplementationInfo_MediationAdapterVersion)
95+
mediationAdapterVersion: adaptersVersionString)
9096

9197
// Ad placement instantiation
9298
return SASAdPlacement(siteId: siteId, pageName: pageId!, formatId: formatId, keywordTargeting: targetingString)

displaysdk8/SASGMAUtils.swift

Lines changed: 15 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,10 @@ class SASGMAAdNetworkExtras: NSObject, GADAdNetworkExtras {
2222
class SASGMAUtils {
2323

2424
static let SASImplementationInfo_PrimarySDKName = "GoogleMobileAds"
25-
static let SASImplementationInfo_MediationAdapterVersion = "2.0.0"
25+
static let SASImplementationInfo_MediationAdapterVersion_Major = 2
26+
static let SASImplementationInfo_MediationAdapterVersion_Minor = 0
27+
static let SASImplementationInfo_MediationAdapterVersion_Patch = 0
28+
static let adaptersVersionString = "\(SASImplementationInfo_MediationAdapterVersion_Major).\(SASImplementationInfo_MediationAdapterVersion_Minor).\(SASImplementationInfo_MediationAdapterVersion_Patch)"
2629

2730
static private let customEventServerSeparatorString = "/"
2831

@@ -32,15 +35,18 @@ class SASGMAUtils {
3235
static let kSASGMAErrorCodeFailToLoadNativeAd = 102
3336

3437
static func adapterVersion() -> GADVersionNumber {
35-
return GADVersionNumber.init(majorVersion: 3, minorVersion: 0, patchVersion: 0)
38+
return GADVersionNumber.init(majorVersion: SASImplementationInfo_MediationAdapterVersion_Major,
39+
minorVersion: SASImplementationInfo_MediationAdapterVersion_Minor,
40+
patchVersion: SASImplementationInfo_MediationAdapterVersion_Patch)
3641
}
3742

3843
static func adSDKVersion() -> GADVersionNumber {
3944
let versions = SASFrameworkInfo.shared.frameworkVersionString.components(separatedBy: ".")
40-
guard versions.count == 3 else {
41-
return GADVersionNumber.init(majorVersion: 7, minorVersion: 0, patchVersion: 0)
42-
}
43-
return GADVersionNumber.init(majorVersion: Int(versions[0]) ?? 7, minorVersion: Int(versions[1]) ?? 0, patchVersion: Int(versions[2]) ?? 0)
45+
let majorVersion = versions.indices.contains(0) ? Int(versions[0]) ?? 0 : 0
46+
let minorVersion = versions.indices.contains(1) ? Int(versions[1]) ?? 0 : 0
47+
let patchVersion = versions.indices.contains(2) ? Int(versions[2]) ?? 0 : 0
48+
49+
return GADVersionNumber.init(majorVersion: majorVersion, minorVersion: minorVersion, patchVersion: patchVersion)
4450
}
4551

4652
static func placementWith(adConfiguration: GADMediationAdConfiguration) -> SASAdPlacement? {
@@ -84,9 +90,10 @@ class SASGMAUtils {
8490

8591
// Configure the Equativ Display SDK
8692
SASConfiguration.shared.configure()
93+
8794
SASConfiguration.shared.secondaryImplementationInfo = SASSecondaryImplementationInfo(primarySDKName: SASImplementationInfo_PrimarySDKName,
8895
primarySDKVersion: GADGetStringFromVersionNumber(GADMobileAds.sharedInstance().versionNumber),
89-
mediationAdapterVersion: SASImplementationInfo_MediationAdapterVersion)
96+
mediationAdapterVersion: adaptersVersionString)
9097

9198
// Ad placement instantiation
9299
return SASAdPlacement(siteId: siteId, pageId: pageId, formatId: formatId, keywordTargeting: targetingString)
@@ -142,7 +149,7 @@ class SASGMAUtils {
142149
SASConfiguration.shared.configure()
143150
SASConfiguration.shared.secondaryImplementationInfo = SASSecondaryImplementationInfo(primarySDKName: SASImplementationInfo_PrimarySDKName,
144151
primarySDKVersion: GADGetStringFromVersionNumber(GADMobileAds.sharedInstance().versionNumber),
145-
mediationAdapterVersion: SASImplementationInfo_MediationAdapterVersion)
152+
mediationAdapterVersion: adaptersVersionString)
146153

147154
// Ad placement instantiation
148155
return SASAdPlacement(siteId: siteId, pageId: pageId, formatId: formatId, keywordTargeting: targetingString)

0 commit comments

Comments
 (0)