Skip to content

Commit 36f8718

Browse files
author
iluz
committed
Add position param to onCreateHeaderViewHolder, so we can create different view holders
1 parent 70980fb commit 36f8718

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

library/src/main/java/com/timehop/stickyheadersrecyclerview/StickyRecyclerHeadersAdapter.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,10 @@ public interface StickyRecyclerHeadersAdapter<VH extends RecyclerView.ViewHolder
2020
* to inflate the layout for the header.
2121
*
2222
* @param parent the view to create a header view holder for
23+
* @param position the position of the item to create the view holder for.
2324
* @return the view holder
2425
*/
25-
VH onCreateHeaderViewHolder(ViewGroup parent);
26+
VH onCreateHeaderViewHolder(ViewGroup parent, int position);
2627

2728
/**
2829
* Binds an existing ViewHolder to the specified adapter position.

library/src/main/java/com/timehop/stickyheadersrecyclerview/caching/HeaderViewCache.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public View getHeader(RecyclerView parent, int position) {
3131
View header = mHeaderViews.get(headerId);
3232
if (header == null) {
3333
//TODO - recycle views
34-
RecyclerView.ViewHolder viewHolder = mAdapter.onCreateHeaderViewHolder(parent);
34+
RecyclerView.ViewHolder viewHolder = mAdapter.onCreateHeaderViewHolder(parent, position);
3535
mAdapter.onBindHeaderViewHolder(viewHolder, position);
3636
header = viewHolder.itemView;
3737
if (header.getLayoutParams() == null) {

sample/src/main/java/com/timehop/stickyheadersrecyclerview/sample/MainActivity.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -142,7 +142,7 @@ public long getHeaderId(int position) {
142142
}
143143

144144
@Override
145-
public RecyclerView.ViewHolder onCreateHeaderViewHolder(ViewGroup parent) {
145+
public RecyclerView.ViewHolder onCreateHeaderViewHolder(ViewGroup parent, int position) {
146146
View view = LayoutInflater.from(parent.getContext())
147147
.inflate(R.layout.view_header, parent, false);
148148
return new RecyclerView.ViewHolder(view) {

0 commit comments

Comments
 (0)