Skip to content

Commit afa4efb

Browse files
authored
fix: fix resolution detection (#133)
* fix: fix UI skin/scene resolution mismatch and readd screen resolution detection * fix: fix build in vs2022
1 parent 2145ada commit afa4efb

File tree

5 files changed

+11
-18
lines changed

5 files changed

+11
-18
lines changed

CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ target_link_libraries(MinecraftClient PRIVATE
5454
MinecraftWorld
5555
d3d11
5656
XInput9_1_0
57+
Shcore
5758
"${CMAKE_CURRENT_SOURCE_DIR}/Minecraft.Client/Windows64/Iggy/lib/iggy_w64.lib"
5859
"${CMAKE_CURRENT_SOURCE_DIR}/Minecraft.Client/Windows64/Miles/lib/mss64.lib"
5960
$<$<CONFIG:Debug>:

Minecraft.Client/Common/UI/UIController.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -426,7 +426,7 @@ void UIController::loadSkins()
426426
#elif defined __PSVITA__
427427
platformSkinPath = L"skinVita.swf";
428428
#elif defined _WINDOWS64
429-
if(m_fScreenHeight>=1080.0f)
429+
if(m_fScreenHeight>720.0f)
430430
{
431431
platformSkinPath = L"skinHDWin.swf";
432432
}
@@ -435,7 +435,7 @@ void UIController::loadSkins()
435435
platformSkinPath = L"skinWin.swf";
436436
}
437437
#elif defined _DURANGO
438-
if(m_fScreenHeight>=1080.0f)
438+
if(m_fScreenHeight>720.0f)
439439
{
440440
platformSkinPath = L"skinHDDurango.swf";
441441
}
@@ -444,7 +444,7 @@ void UIController::loadSkins()
444444
platformSkinPath = L"skinDurango.swf";
445445
}
446446
#elif defined __ORBIS__
447-
if(m_fScreenHeight>=1080.0f)
447+
if(m_fScreenHeight>720.0f)
448448
{
449449
platformSkinPath = L"skinHDOrbis.swf";
450450
}
@@ -455,7 +455,7 @@ void UIController::loadSkins()
455455

456456
#endif
457457
// Every platform has one of these, so nothing shared
458-
if(m_fScreenHeight>=1080.0f)
458+
if(m_fScreenHeight>720.0f)
459459
{
460460
m_iggyLibraries[eLibrary_Platform] = loadSkin(platformSkinPath, L"platformskinHD.swf");
461461
}

Minecraft.Client/Minecraft.Client.vcxproj

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1296,7 +1296,7 @@ if not exist "$(TargetDir)\savedata" mkdir "$(TargetDir)\savedata"</Command>
12961296
<Link>
12971297
<GenerateDebugInformation>true</GenerateDebugInformation>
12981298
<ProgramDatabaseFile>$(OutDir)$(ProjectName).pdb</ProgramDatabaseFile>
1299-
<AdditionalDependencies>d3d11.lib;..\Minecraft.World\x64_Debug\Minecraft.World.lib;%(AdditionalDependencies);XInput9_1_0.lib;..\Minecraft.Client\Windows64\Miles\Lib\mss64.lib</AdditionalDependencies>
1299+
<AdditionalDependencies>d3d11.lib;Shcore.lib;..\Minecraft.World\x64_Debug\Minecraft.World.lib;%(AdditionalDependencies);XInput9_1_0.lib;..\Minecraft.Client\Windows64\Miles\Lib\mss64.lib</AdditionalDependencies>
13001300
<ShowProgress>NotSet</ShowProgress>
13011301
<SuppressStartupBanner>false</SuppressStartupBanner>
13021302
<ForceFileOutput>MultiplyDefinedSymbolOnly</ForceFileOutput>
@@ -1429,7 +1429,7 @@ xcopy /q /y /i /s /e $(ProjectDir)Durango\CU $(LayoutDir)Image\Loose\CU</Comman
14291429
<Link>
14301430
<GenerateDebugInformation>true</GenerateDebugInformation>
14311431
<ProgramDatabaseFile>$(OutDir)$(ProjectName).pdb</ProgramDatabaseFile>
1432-
<AdditionalDependencies>d3d11.lib;..\Minecraft.World\x64_Release\Minecraft.World.lib;XInput9_1_0.lib;Windows64\Iggy\lib\iggy_w64.lib;%(AdditionalDependencies)</AdditionalDependencies>
1432+
<AdditionalDependencies>d3d11.lib;Shcore.lib;..\Minecraft.World\x64_Release\Minecraft.World.lib;XInput9_1_0.lib;Windows64\Iggy\lib\iggy_w64.lib;%(AdditionalDependencies)</AdditionalDependencies>
14331433
<ShowProgress>NotSet</ShowProgress>
14341434
<SuppressStartupBanner>false</SuppressStartupBanner>
14351435
</Link>
@@ -1474,7 +1474,7 @@ xcopy /q /y /i /s /e $(ProjectDir)Durango\CU $(LayoutDir)Image\Loose\CU</Comman
14741474
<Link>
14751475
<GenerateDebugInformation>true</GenerateDebugInformation>
14761476
<ProgramDatabaseFile>$(OutDir)$(ProjectName).pdb</ProgramDatabaseFile>
1477-
<AdditionalDependencies>d3d11.lib;..\Minecraft.World\x64_Release\Minecraft.World.lib;XInput9_1_0.lib;Windows64\Iggy\lib\iggy_w64.lib;%(AdditionalDependencies)</AdditionalDependencies>
1477+
<AdditionalDependencies>d3d11.lib;Shcore.lib;..\Minecraft.World\x64_Release\Minecraft.World.lib;XInput9_1_0.lib;Windows64\Iggy\lib\iggy_w64.lib;%(AdditionalDependencies)</AdditionalDependencies>
14781478
<ShowProgress>NotSet</ShowProgress>
14791479
<SuppressStartupBanner>false</SuppressStartupBanner>
14801480
</Link>

Minecraft.Client/Windows64/Windows64_Minecraft.cpp

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
#include "stdafx.h"
55

66
#include <assert.h>
7+
#include <ShellScalingApi.h>
78
#include "GameConfig\Minecraft.spa.h"
89
#include "..\MinecraftServer.h"
910
#include "..\LocalPlayer.h"
@@ -716,20 +717,10 @@ int APIENTRY _tWinMain(_In_ HINSTANCE hInstance,
716717
UNREFERENCED_PARAMETER(hPrevInstance);
717718
UNREFERENCED_PARAMETER(lpCmdLine);
718719

719-
/*
720-
// Declare DPI awareness so GetSystemMetrics returns physical pixels
721-
SetProcessDPIAware();
720+
SetProcessDpiAwareness(PROCESS_PER_MONITOR_DPI_AWARE);
722721
g_iScreenWidth = GetSystemMetrics(SM_CXSCREEN);
723722
g_iScreenHeight = GetSystemMetrics(SM_CYSCREEN);
724723

725-
{
726-
char buf[128];
727-
sprintf(buf, "Screen resolution: %dx%d\n", g_iScreenWidth, g_iScreenHeight);
728-
OutputDebugStringA(buf);
729-
}
730-
*/
731-
732-
733724
if(lpCmdLine)
734725
{
735726
if(lpCmdLine[0] == '1')

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ This project contains the source code of Minecraft Legacy Console Edition v1.3.0
1616
- Added support for keyboard and mouse input
1717
- Added fullscreen mode support (toggle using F11)
1818
- Disabled V-Sync for better performance
19+
- Device's screen resolution will be used as the game resolution instead of using a fixed resolution (1920x1080)
1920

2021
## Controls (Keyboard & Mouse)
2122

0 commit comments

Comments
 (0)