Skip to content

Fix: ccip 1.6 bidirectional lookup#1

Merged
bukata-sa merged 1 commit intomainfrom
fix/ccip_bidirectional_lookup
Apr 9, 2025
Merged

Fix: ccip 1.6 bidirectional lookup#1
bukata-sa merged 1 commit intomainfrom
fix/ccip_bidirectional_lookup

Conversation

@bukata-sa
Copy link
Collaborator

No description provided.

@bukata-sa bukata-sa requested a review from Copilot April 9, 2025 14:30
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

pkg/alerts.go:157

  • Review the early return in the loop to ensure that returning after the first matching off ramp is intentional; if multiple valid off ramps are expected, consider collecting all matches or adding a clarifying comment.
return GlobalInputContracts{

pkg/alerts.go:104

  • Consider updating or adding unit tests to cover the updated bidirectional lookup logic and the new parameter ordering in lookupCCIPv1_6.
contractsSrc := lookupCCIPv1_6(ccipView, srcChain, destChain)

@bukata-sa bukata-sa merged commit 3830620 into main Apr 9, 2025
2 checks passed
@bukata-sa bukata-sa deleted the fix/ccip_bidirectional_lookup branch May 13, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments