Clippy fixes (#1124)

* Print clippy version on CI

* First bunch of lint fixes

* More clippy fixes

* div_ceil lint

Author: toblich

.github/workflows/solana.yml

@@ -121,6 +121,7 @@ jobs:
           cd /solana/contracts &&\
           anchor build &&\
           cargo check &&\
+          cargo clippy -- --version &&\
           cargo clippy -- -D warnings &&\
           cargo test --workspace"
 

chains/solana/contracts/crates/build-commit/src/lib.rs

@@ -11,15 +11,12 @@ pub fn cargo_instructions(source_file: &str, version: &str) {
 
     // ensure it is re-run when the build script changes
     println!("cargo:rerun-if-changed=build.rs");
-    println!("cargo:rerun-if-changed={}", source_file);
+    println!("cargo:rerun-if-changed={source_file}");
     println!("cargo:rerun-if-changed={}", file!());
 
     // set environment variables for the build
-    println!("cargo:rustc-env=CCIP_BUILD_PROGRAM_NAME={}", program_name);
-    println!(
-        "cargo:rustc-env=CCIP_BUILD_TYPE_VERSION={} {}",
-        program_name, version,
-    );
+    println!("cargo:rustc-env=CCIP_BUILD_PROGRAM_NAME={program_name}");
+    println!("cargo:rustc-env=CCIP_BUILD_TYPE_VERSION={program_name} {version}");
 }
 
 #[cfg(test)]

chains/solana/contracts/programs/access-controller/Cargo.toml

@@ -19,3 +19,7 @@ anchor-lang = "0.29.0"
 bytemuck = { version = "1.4.0", features = ["derive", "min_const_generics"]}
 static_assertions = "1.1.0"
 arrayvec = { version = "1.0.0", path = "../../crates/arrayvec" }
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = ['cfg(target_os, values("solana"))', 'cfg(feature, values("anchor-debug", "custom-panic", "no-log-ix-name"))']

chains/solana/contracts/programs/base-token-pool/Cargo.toml

@@ -21,3 +21,7 @@ anchor-spl = "0.29.0"
 solana-program = "1.17.25" # pin solana to 1.17
 spl-math = { version = "0.2.0", features = [ "no-entrypoint" ] }
 rmn_remote = {path = "../rmn-remote", features = ["cpi"]}
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = ['cfg(target_os, values("solana"))', 'cfg(feature, values("anchor-debug", "custom-panic"))']

chains/solana/contracts/programs/burnmint-token-pool/Cargo.toml

@@ -26,3 +26,7 @@ ccip_common = {path = "../ccip-common"}
 
 [build-dependencies]
 build_commit = { path = "../../crates/build-commit" }
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = ['cfg(target_os, values("solana"))', 'cfg(feature, values("anchor-debug", "custom-panic"))']

chains/solana/contracts/programs/ccip-common/Cargo.toml

@@ -20,4 +20,8 @@ default = ["no-entrypoint"]
 solana-program = "1.17.25" # pin solana to 1.17
 anchor-lang = { version = "0.29.0", features = ["init-if-needed"] }
 anchor-spl = "0.29.0"
-ethnum = "1.5"
+ethnum = "1.5"
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = ['cfg(target_os, values("solana"))', 'cfg(feature, values("anchor-debug", "custom-panic"))']

chains/solana/contracts/programs/ccip-offramp/Cargo.toml

@@ -30,3 +30,7 @@ hex = "0.4.3"
 
 [build-dependencies]
 build_commit = { path = "../../crates/build-commit" }
+
+[lints.rust.unexpected_cfgs]
+level = "warn"
+check-cfg = ['cfg(target_os, values("solana"))', 'cfg(feature, values("anchor-debug", "custom-panic", "custom-heap"))']

chains/solana/contracts/programs/ccip-offramp/src/instructions/router.rs

@@ -3,6 +3,7 @@ use crate::state::CodeVersion;
 use super::interfaces::*;
 use super::v1;
 
+#[allow(clippy::empty_line_after_doc_comments)]
 /**
  * This file routes traffic between multiple versions of our business logic, which can be upgraded in a
  * backwards-compatible way and so we can gradually shift traffic between versions (and rollback if there are issues).

chains/solana/contracts/programs/ccip-offramp/src/instructions/v1/buffering.rs

@@ -174,9 +174,16 @@ pub fn deserialize_from_buffer_account(
     ))
 }
 
+// Using a.div_ceil(b) is unstable on Rust 1.68, so we implement our own version even though clippy may complain.
+// See https://github.com/rust-lang/rust/issues/88581 for more info.
+// Whenever we upgrade Anchor & Rust, we can remove this.
 fn div_ceil<T: Into<u32>>(a: T, b: T) -> u32 {
     let (a, b) = (a.into(), b.into());
     assert!(a + b - 1 > 0);
+
+    // on newer rust version, this would require #[allow(clippy::manual_div_ceil)]
+    // or be replaced with `a.div_ceil(b)` directly. However, on older rust versions,
+    // there is no support for clippy's lint and the div_ceil method is unstable.
     (a + b - 1) / b
 }
 

chains/solana/contracts/programs/ccip-offramp/src/lib.rs

@@ -23,6 +23,7 @@ pub mod ccip_offramp {
 
     use super::*;
 
+    #[allow(clippy::empty_line_after_outer_attr)]
     //////////////////////////
     /// Initialization Flow //
     //////////////////////////
@@ -144,6 +145,7 @@ pub mod ccip_offramp {
         router::admin(default_code_version).accept_ownership(ctx)
     }
 
+    #[allow(clippy::empty_line_after_outer_attr)]
     /////////////
     // Config //
     /////////////
@@ -360,6 +362,7 @@ pub mod ccip_offramp {
         )
     }
 
+    #[allow(clippy::empty_line_after_outer_attr)]
     ////////////////////
     /// Off Ramp Flow //
     ////////////////////