execute: remove inflight cache checking in outcome (#1320)

makramkd · web-flow · commit 520275eaaf00 · 2025-10-24T07:13:56.000Z
diff --git a/execute/observation.go b/execute/observation.go
@@ -311,7 +311,7 @@ func (p *Plugin) readMessagesForReport(
 	return msgs, nil
 }
 
-// createEmptyMessageWithIDAndSeqNum creates a message with just the sequence number set
+// createEmptyMessageWithIDAndSeqNum creates a message with just the message ID and sequence number set in the header.
 func createEmptyMessageWithIDAndSeqNum(msg cciptypes.Message) cciptypes.Message {
 	return cciptypes.Message{
 		Header: cciptypes.RampMessageHeader{
diff --git a/execute/outcome.go b/execute/outcome.go
@@ -188,8 +188,6 @@ func (p *Plugin) getFilterOutcome(
 		report.WithMaxReportSizeBytes(maxReportLength),
 		report.WithMaxGas(p.offchainCfg.BatchGasLimit),
 		report.WithExtraMessageCheck(report.CheckNonces(observation.Nonces, p.addrCodec)),
-		//TODO: remove as we already check it in GetMessages phase
-		report.WithExtraMessageCheck(report.CheckIfInflight(p.inflightMessageCache.IsInflight)),
 		report.WithMaxMessages(p.offchainCfg.MaxReportMessages),
 		report.WithMaxSingleChainReports(p.offchainCfg.MaxSingleChainReports),
 	)

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ func (p *Plugin) readMessagesForReport(`
`311`	`311`	`return msgs, nil`
`312`	`312`	`}`
`313`	`313`
`314`		`-// createEmptyMessageWithIDAndSeqNum creates a message with just the sequence number set`
	`314`	`+// createEmptyMessageWithIDAndSeqNum creates a message with just the message ID and sequence number set in the header.`
`315`	`315`	`func createEmptyMessageWithIDAndSeqNum(msg cciptypes.Message) cciptypes.Message {`
`316`	`316`	`return cciptypes.Message{`
`317`	`317`	`Header: cciptypes.RampMessageHeader{`
Original file line number	Diff line number	Diff line change
`@@ -188,8 +188,6 @@ func (p *Plugin) getFilterOutcome(`
`188`	`188`	`report.WithMaxReportSizeBytes(maxReportLength),`
`189`	`189`	`report.WithMaxGas(p.offchainCfg.BatchGasLimit),`
`190`	`190`	`report.WithExtraMessageCheck(report.CheckNonces(observation.Nonces, p.addrCodec)),`
`191`		`- //TODO: remove as we already check it in GetMessages phase`
`192`		`- report.WithExtraMessageCheck(report.CheckIfInflight(p.inflightMessageCache.IsInflight)),`
`193`	`191`	`report.WithMaxMessages(p.offchainCfg.MaxReportMessages),`
`194`	`192`	`report.WithMaxSingleChainReports(p.offchainCfg.MaxSingleChainReports),`
`195`	`193`	`)`