Skip to content

Commit 1a0af5f

Browse files
authored
Merge branch 'main' into chore/CRE-954-wasm-host-log-limits
2 parents 62a9019 + a242e4b commit 1a0af5f

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

pkg/settings/cresettings/defaults.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
"WorkflowLimit": "200",
33
"WorkflowRegistrationQueueLimit": "20",
44
"WorkflowExecutionConcurrencyLimit": "50",
5+
"WorkflowTriggerRateLimit": "200rps:200",
56
"GatewayUnauthenticatedRequestRateLimit": "100rps:-1",
67
"GatewayUnauthenticatedRequestRateLimitPerIP": "1rps:-1",
78
"GatewayIncomingPayloadSizeLimit": "10kb",
@@ -10,7 +11,8 @@
1011
"ZeroBalancePruningTimeout": "24h0m0s"
1112
},
1213
"PerOwner": {
13-
"WorkflowExecutionConcurrencyLimit": "50"
14+
"WorkflowExecutionConcurrencyLimit": "50",
15+
"WorkflowTriggerRateLimit": "200rps:200"
1416
},
1517
"PerWorkflow": {
1618
"TriggerLimit": "10",
@@ -40,7 +42,6 @@
4042
"RateLimit": "every30s:3"
4143
},
4244
"LogTrigger": {
43-
"RateLimit": "every10s:-1",
4445
"Limit": "5",
4546
"EventRateLimit": "every6s:10",
4647
"FilterAddressLimit": "5",

pkg/settings/cresettings/defaults.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
WorkflowLimit = '200'
22
WorkflowRegistrationQueueLimit = '20'
33
WorkflowExecutionConcurrencyLimit = '50'
4+
WorkflowTriggerRateLimit = '200rps:200'
45
GatewayUnauthenticatedRequestRateLimit = '100rps:-1'
56
GatewayUnauthenticatedRequestRateLimitPerIP = '1rps:-1'
67
GatewayIncomingPayloadSizeLimit = '10kb'
@@ -11,6 +12,7 @@ ZeroBalancePruningTimeout = '24h0m0s'
1112

1213
[PerOwner]
1314
WorkflowExecutionConcurrencyLimit = '50'
15+
WorkflowTriggerRateLimit = '200rps:200'
1416

1517
[PerWorkflow]
1618
TriggerLimit = '10'
@@ -41,7 +43,6 @@ RateLimit = 'every30s:1'
4143
RateLimit = 'every30s:3'
4244

4345
[PerWorkflow.LogTrigger]
44-
RateLimit = 'every10s:-1'
4546
Limit = '5'
4647
EventRateLimit = 'every6s:10'
4748
FilterAddressLimit = '5'

pkg/settings/cresettings/settings.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ var Default = Schema{
3434
WorkflowLimit: Int(200),
3535
WorkflowRegistrationQueueLimit: Int(20),
3636
WorkflowExecutionConcurrencyLimit: Int(50),
37+
WorkflowTriggerRateLimit: Rate(200, 200),
3738
GatewayUnauthenticatedRequestRateLimit: Rate(rate.Every(time.Second/100), -1),
3839
GatewayUnauthenticatedRequestRateLimitPerIP: Rate(rate.Every(time.Second), -1),
3940
GatewayIncomingPayloadSizeLimit: Size(10 * config.KByte),
@@ -44,6 +45,7 @@ var Default = Schema{
4445
},
4546
PerOwner: Owners{
4647
WorkflowExecutionConcurrencyLimit: Int(50),
48+
WorkflowTriggerRateLimit: Rate(200, 200),
4749
},
4850
PerWorkflow: Workflows{
4951
TriggerLimit: Int(10),
@@ -73,9 +75,8 @@ var Default = Schema{
7375
RateLimit: Rate(rate.Every(30*time.Second), 3),
7476
},
7577
LogTrigger: logTrigger{
76-
RateLimit: Rate(rate.Every(10*time.Second), -1), //TODO
7778
Limit: Int(5),
78-
EventRateLimit: Rate(rate.Every(time.Minute/10), 10), // TODO
79+
EventRateLimit: Rate(rate.Every(time.Minute/10), 10),
7980
FilterAddressLimit: Int(5),
8081
FilterTopicsPerSlotLimit: Int(10),
8182
},
@@ -91,7 +92,7 @@ var Default = Schema{
9192
TargetsLimit: Int(3),
9293
ReportSizeLimit: Size(config.KByte),
9394
EVM: evmChainWrite{
94-
TransactionGasLimit: Uint64(500_000), //TODO
95+
TransactionGasLimit: Uint64(500_000),
9596
},
9697
},
9798
ChainRead: chainRead{
@@ -106,6 +107,7 @@ type Schema struct {
106107
WorkflowLimit Setting[int] `unit:"{workflow}"`
107108
WorkflowRegistrationQueueLimit Setting[int] `unit:"{workflow}"`
108109
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
110+
WorkflowTriggerRateLimit Setting[config.Rate]
109111
GatewayUnauthenticatedRequestRateLimit Setting[config.Rate]
110112
GatewayUnauthenticatedRequestRateLimitPerIP Setting[config.Rate]
111113
GatewayIncomingPayloadSizeLimit Setting[config.Size]
@@ -121,6 +123,7 @@ type Orgs struct {
121123

122124
type Owners struct {
123125
WorkflowExecutionConcurrencyLimit Setting[int] `unit:"{workflow}"`
126+
WorkflowTriggerRateLimit Setting[config.Rate]
124127
}
125128

126129
type Workflows struct {
@@ -166,7 +169,6 @@ type httpTrigger struct {
166169
RateLimit Setting[config.Rate]
167170
}
168171
type logTrigger struct {
169-
RateLimit Setting[config.Rate]
170172
Limit Setting[int] `unit:"{trigger}"`
171173
EventRateLimit Setting[config.Rate]
172174
FilterAddressLimit Setting[int] `unit:"{address}"`

0 commit comments

Comments
 (0)