Skip to content

Commit 2b52746

Browse files
committed
fix converters
1 parent 5c11c19 commit 2b52746

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

pkg/chains/solana/proto_helpers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,15 +1419,15 @@ func ConvertValueComparatorsToProto(comparators []solprimitives.IndexedValueComp
14191419
return nil
14201420
}
14211421

1422-
out := make([]*IndexedValueComparator, len(comparators))
1422+
out := make([]*IndexedValueComparator, 0)
14231423
for _, c := range comparators {
14241424
out = append(out, &IndexedValueComparator{
14251425
Value: c.Value,
14261426
Operator: chaincommonpb.ComparisonOperator(c.Operator),
14271427
})
14281428
}
14291429

1430-
return nil
1430+
return out
14311431
}
14321432

14331433
func ConvertValueCompraratorsFromProto(comparators []*IndexedValueComparator) []solprimitives.IndexedValueComparator {

pkg/chains/solana/proto_helpers_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -291,17 +291,17 @@ func TestExpressions_Roundtrip_SolanaPrimitives(t *testing.T) {
291291
{Value: typesolana.IndexedValue{1, 2, 3}, Operator: 0},
292292
})
293293

294-
root := query.Or(query.And(a, e), evBy)
295-
294+
expressions := []query.Expression{a, e, evBy}
296295
// to proto
297-
pb, err := conv.ConvertExpressionsToProto([]query.Expression{root})
296+
pb, err := conv.ConvertExpressionsToProto(expressions)
298297
require.NoError(t, err)
299-
require.Len(t, pb, 1)
298+
require.Len(t, pb, 3)
300299

301300
// from proto
302301
round, err := conv.ConvertExpressionsFromProto(pb)
303302
require.NoError(t, err)
304-
require.Len(t, round, 1)
303+
require.Len(t, round, 3)
304+
require.Equal(t, expressions, round)
305305
}
306306

307307
func TestLPFilterAndSubkeysConverters(t *testing.T) {

0 commit comments

Comments
 (0)