cre-1601: comment improvement

mchain0 · mchain0 · commit 57f042310012 · 2025-12-30T10:34:08.000+01:00
diff --git a/pkg/workflows/ring/plugin.go b/pkg/workflows/ring/plugin.go
@@ -218,7 +218,8 @@ func (p *Plugin) calculateNextState(priorState *pb.RoutingState, wantShards uint
 		}, nil
 
 	case *pb.RoutingState_Transition:
-		// Wait for all nodes to sync before committing to new shard assignments
+		// Cannot commit to new routing until safety period elapses: some nodes may still
+		// be on the prior stable state and changing routes now would cause misalignment
 		if now.Before(ps.Transition.ChangesSafeAfter.AsTime()) {
 			return priorState, nil
 		}

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,8 @@ func (p Plugin) calculateNextState(priorState pb.RoutingState, wantShards uint`
`218`	`218`	`}, nil`
`219`	`219`
`220`	`220`	`case *pb.RoutingState_Transition:`
`221`		`- // Wait for all nodes to sync before committing to new shard assignments`
	`221`	`+ // Cannot commit to new routing until safety period elapses: some nodes may still`
	`222`	`+ // be on the prior stable state and changing routes now would cause misalignment`
`222`	`223`	`if now.Before(ps.Transition.ChangesSafeAfter.AsTime()) {`
`223`	`224`	`return priorState, nil`
`224`	`225`	`}`