Remove context from GetDONTime (#1471)

* Use node time

* Update execution.go

* Remove ctx

* Use Node Mode for clockTimeGet

* Undo secondary hook

* Use mode

Author: DylanTinianov

pkg/workflows/wasm/host/execution.go

@@ -166,6 +166,8 @@ func (e *execution[T]) switchModes(_ *wasmtime.Caller, mode int32) {
 	e.mode = sdkpb.Mode(mode)
 }
 
+// clockTimeGet is the default time.Now() which is also called by Go many times.
+// This implementation uses Node Mode to not have to wait for OCR rounds.
 func (e *execution[T]) clockTimeGet(caller *wasmtime.Caller, id int32, precision int64, resultTimestamp int32) int32 {
 	donTime, err := e.timeFetcher.GetTime(e.mode)
 	if err != nil {

pkg/workflows/wasm/host/mock_execution_helper_test.go

@@ -100,7 +100,7 @@ type ExecutionHelper interface {
 
 	GetNodeTime() time.Time
 
-	GetDONTime(ctx context.Context) (time.Time, error)
+	GetDONTime() (time.Time, error)
 
 	EmitUserLog(log string) error
 }

pkg/workflows/wasm/host/module.go

@@ -79,7 +79,7 @@ func TestStandardCapabilityCallsAreAsync(t *testing.T) {
 	mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 		return time.Now()
 	}).Maybe()
-	mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+	mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 		return time.Now(), nil
 	}).Maybe()
 	m := makeTestModule(t)
@@ -131,7 +131,7 @@ func TestStandardModeSwitch(t *testing.T) {
 		})
 
 		// We want to make sure time.Now() is called at least twice in DON mode and once in node Mode
-		mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+		mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 			if nodeCall {
 				donCall2 = true
 			} else {
@@ -168,7 +168,7 @@ func TestStandardModeSwitch(t *testing.T) {
 		mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 			return time.Now()
 		}).Maybe()
-		mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+		mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 			return time.Now(), nil
 		}).Maybe()
 		mockExecutionHelper.EXPECT().CallCapability(mock.Anything, mock.Anything).RunAndReturn(func(_ context.Context, request *pb.CapabilityRequest) (*pb.CapabilityResponse, error) {
@@ -193,7 +193,7 @@ func TestStandardModeSwitch(t *testing.T) {
 		mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 			return time.Now()
 		}).Maybe()
-		mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+		mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 			return time.Now(), nil
 		}).Maybe()
 		mockExecutionHelper.EXPECT().CallCapability(mock.Anything, mock.Anything).RunAndReturn(func(_ context.Context, request *pb.CapabilityRequest) (*pb.CapabilityResponse, error) {
@@ -228,7 +228,7 @@ func TestStandardLogging(t *testing.T) {
 	mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 		return time.Now()
 	}).Maybe()
-	mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+	mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 		return time.Now(), nil
 	}).Maybe()
 	mockExecutionHelper.EXPECT().EmitUserLog(mock.Anything).RunAndReturn(func(s string) error {
@@ -346,7 +346,7 @@ func TestStandardRandom(t *testing.T) {
 	gte100Exec.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 		return time.Now()
 	}).Maybe()
-	gte100Exec.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+	gte100Exec.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 		return time.Now(), nil
 	}).Maybe()
 	// RunAndReturn
@@ -376,7 +376,7 @@ func TestStandardRandom(t *testing.T) {
 		lt100Exec.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 			return time.Now()
 		}).Maybe()
-		lt100Exec.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+		lt100Exec.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 			return time.Now(), nil
 		}).Maybe()
 
@@ -400,7 +400,7 @@ func TestStandardRandom(t *testing.T) {
 		gte100Exec2.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 			return time.Now()
 		}).Maybe()
-		gte100Exec2.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+		gte100Exec2.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 			return time.Now(), nil
 		}).Maybe()
 
@@ -576,7 +576,7 @@ func runSecretTest(t *testing.T, m *module, secretResponse *pb.SecretResponse) *
 	mockExecutionHelper.EXPECT().GetNodeTime().RunAndReturn(func() time.Time {
 		return time.Now()
 	}).Maybe()
-	mockExecutionHelper.EXPECT().GetDONTime(mock.Anything).RunAndReturn(func(ctx context.Context) (time.Time, error) {
+	mockExecutionHelper.EXPECT().GetDONTime().RunAndReturn(func() (time.Time, error) {
 		return time.Now(), nil
 	}).Maybe()
 

pkg/workflows/wasm/host/standard_test.go

@@ -64,7 +64,7 @@ func (t *timeFetcher) runLoop() {
 
 			switch mode {
 			case sdkpb.Mode_MODE_DON:
-				donTime, err = t.executor.GetDONTime(t.ctx)
+				donTime, err = t.executor.GetDONTime()
 			default:
 				donTime = t.executor.GetNodeTime()
 			}

pkg/workflows/wasm/host/time.go

@@ -6,7 +6,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 
 	"github.com/smartcontractkit/chainlink-common/pkg/workflows/sdk/v2/pb"
@@ -34,7 +33,7 @@ func TestTimeFetcher_GetTime_DON(t *testing.T) {
 
 	mockExec := NewMockExecutionHelper(t)
 	expected := time.Now()
-	mockExec.EXPECT().GetDONTime(mock.Anything).Return(expected, nil)
+	mockExec.EXPECT().GetDONTime().Return(expected, nil)
 
 	tf := newTimeFetcher(ctx, mockExec)
 	tf.Start()
@@ -49,7 +48,7 @@ func TestTimeFetcher_GetTime_DON_Error(t *testing.T) {
 	defer cancel()
 
 	mockExec := NewMockExecutionHelper(t)
-	mockExec.EXPECT().GetDONTime(mock.Anything).Return(time.Time{}, errors.New("don error"))
+	mockExec.EXPECT().GetDONTime().Return(time.Time{}, errors.New("don error"))
 
 	tf := newTimeFetcher(ctx, mockExec)
 	tf.Start()
@@ -63,7 +62,7 @@ func TestTimeFetcher_ContextCancelledBeforeRequest(t *testing.T) {
 	cancel()
 
 	mockExec := NewMockExecutionHelper(t)
-	mockExec.EXPECT().GetDONTime(mock.Anything).Return(time.Time{}, context.Canceled).Maybe()
+	mockExec.EXPECT().GetDONTime().Return(time.Time{}, context.Canceled).Maybe()
 
 	tf := newTimeFetcher(ctx, mockExec)
 
@@ -86,7 +85,7 @@ func TestTimeFetcher_ContextCancelledDuringResponse(t *testing.T) {
 	defer cancel()
 
 	mockExec := NewMockExecutionHelper(t)
-	mockExec.EXPECT().GetDONTime(mock.Anything).Run(func(context.Context) {
+	mockExec.EXPECT().GetDONTime().Run(func() {
 		time.Sleep(20 * time.Millisecond) // force timeout
 	}).Return(time.Time{}, nil)