Skip to content

Commit 85557b9

Browse files
committed
adding back commented code and adding TODO item
1 parent e678946 commit 85557b9

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

pkg/types/chains/evm/evm.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,7 @@ func (e *TxError) Error() string {
143143
return fmt.Sprintf("Fail processing Transaction with internal TxID: %s", e.TxID)
144144
}
145145

146+
//PLEX-1524 - Refactor this to return the Tx Hash in a Transaction type and a second return value for the TxStatus. We may even be able to return the whole transaction object instead of just the hash.
146147
type TransactionResult struct {
147148
TxStatus TransactionStatus
148149
TxHash Hash

pkg/types/relayer.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,12 @@ type ChainService interface {
101101

102102
// GethClient is the subset of go-ethereum client methods implemented by EVMService.
103103
type GethClient interface {
104+
// CallContract reads a contract as specified in the call message at a block height defined by blockNumber where:
105+
// blockNumber :
106+
// nil (default) or (-2) → use the latest mined block (“latest”)
107+
// FinalizedBlockNumber(-3) → last finalized block (“finalized”)
108+
//
109+
// Any positive value is treated as an explicit block height.
104110
}
105111

106112
type EVMService interface {

0 commit comments

Comments
 (0)