feat: refactor the implementation to potentially address sonarCube issues.

Author: seanwangsmartcontract

pkg/nodeauth/jwt/node_jwt_authenticator.go

@@ -14,32 +14,30 @@ import (
 	"github.com/smartcontractkit/chainlink-common/pkg/nodeauth/utils"
 )
 
+// NodeJWTAuthenticatorConfig holds configuration for NodeJWTAuthenticator
+type NodeJWTAuthenticatorConfig struct {
+	// Leeway is the time leeway for JWT validation to address clock skew between systems
+	Leeway time.Duration
+}
+
 // NodeJWTAuthenticator is designed to be used by the server-side service to authenticate the JWT token generated by the Node.
 type NodeJWTAuthenticator struct {
 	nodeAuthProvider NodeAuthProvider // Source of truth to validate public key in the JWT claim.
 	parser           *jwt.Parser      // JWT parser to parse the JWT token.
 	logger           *slog.Logger
 }
 
-// NodeJWTAuthenticatorOption is a functional option for configuring NodeJWTAuthenticator
-type NodeJWTAuthenticatorOption func(*[]jwt.ParserOption)
-
-// WithLeeway sets a custom leeway duration for JWT validation to address clock skew between systems
-func WithLeeway(leeway time.Duration) NodeJWTAuthenticatorOption {
-	return func(parserOpts *[]jwt.ParserOption) {
-		*parserOpts = append(*parserOpts, jwt.WithLeeway(leeway))
-	}
-}
-
-func NewNodeJWTAuthenticator(nodeAuthProvider NodeAuthProvider, logger *slog.Logger, opts ...NodeJWTAuthenticatorOption) *NodeJWTAuthenticator {
+func NewNodeJWTAuthenticator(nodeAuthProvider NodeAuthProvider, logger *slog.Logger, config ...*NodeJWTAuthenticatorConfig) *NodeJWTAuthenticator {
 	parserOpts := []jwt.ParserOption{
 		jwt.WithIssuedAt(),
 		jwt.WithExpirationRequired(),
 	}
 
-	// Apply optional configurations (e.g. leeway)
-	for _, opt := range opts {
-		opt(&parserOpts)
+	// Apply optional configuration
+	if len(config) > 0 && config[0] != nil {
+		if config[0].Leeway > 0 {
+			parserOpts = append(parserOpts, jwt.WithLeeway(config[0].Leeway))
+		}
 	}
 
 	parser := jwt.NewParser(parserOpts...)