fix: fix lint issues

Author: agparadiso

observability-lib/cmd/api/notification_policy/delete.go

@@ -5,9 +5,10 @@ import (
 	"strings"
 
 	"github.com/grafana/grafana-foundation-sdk/go/alerting"
+	"github.com/spf13/cobra"
+
 	"github.com/smartcontractkit/chainlink-common/observability-lib/api"
 	"github.com/smartcontractkit/chainlink-common/observability-lib/grafana"
-	"github.com/spf13/cobra"
 )
 
 var deleteCmd = &cobra.Command{
@@ -27,7 +28,7 @@ var deleteCmd = &cobra.Command{
 		if err != nil {
 			return err
 		}
-		if matchers != nil && len(matchers) > 0 {
+		if len(matchers) > 0 {
 			objectMatchers := alerting.ObjectMatchers{}
 			notificationPolicy := alerting.NotificationPolicy{
 				Receiver: grafana.Pointer(args[0]),

observability-lib/grafana/builder.go

@@ -120,7 +120,7 @@ func (b *Builder) AddPanel(panel ...*Panel) {
 			item.polystatPanelBuilder.Id(panelID)
 			b.dashboardBuilder.WithPanel(item.polystatPanelBuilder)
 		}
-		if item.alertBuilders != nil && len(item.alertBuilders) > 0 {
+		if len(item.alertBuilders) > 0 {
 			b.AddAlert(item.alertBuilders...)
 		}
 	}
@@ -161,7 +161,7 @@ func (b *Builder) Build() (*Observability, error) {
 		}
 
 		// Add common tags to alerts
-		if b.alertsTags != nil && len(b.alertsTags) > 0 {
+		if len(b.alertsTags) > 0 {
 			tags := maps.Clone(b.alertsTags)
 			maps.Copy(tags, alert.Labels)
 

observability-lib/grafana/dashboard.go

@@ -7,6 +7,7 @@ import (
 
 	"github.com/grafana/grafana-foundation-sdk/go/alerting"
 	"github.com/grafana/grafana-foundation-sdk/go/dashboard"
+
 	"github.com/smartcontractkit/chainlink-common/observability-lib/api"
 )
 
@@ -73,7 +74,7 @@ func getAlertRules(grafanaClient *api.Client, dashboardUID *string, folderUID st
 	}
 
 	// check for alert rules by folder UID and group name
-	if alertGroups != nil && len(alertGroups) > 0 {
+	if len(alertGroups) > 0 {
 		for _, alertGroup := range alertGroups {
 			alertsRulePerGroup, errGetAlertRulesPerGroup := grafanaClient.GetAlertRulesByFolderUIDAndGroupName(folderUID, *alertGroup.Title)
 			if errGetAlertRulesPerGroup != nil {
@@ -219,7 +220,7 @@ func (o *Observability) DeployToGrafana(options *DeployOptions) error {
 	}
 
 	// Create contact points for the alerts
-	if o.ContactPoints != nil && len(o.ContactPoints) > 0 {
+	if len(o.ContactPoints) > 0 {
 		for _, contactPoint := range o.ContactPoints {
 			errCreateOrUpdateContactPoint := grafanaClient.CreateOrUpdateContactPoint(contactPoint)
 			if errCreateOrUpdateContactPoint != nil {
@@ -229,7 +230,7 @@ func (o *Observability) DeployToGrafana(options *DeployOptions) error {
 	}
 
 	// Create notification policies for the alerts
-	if o.NotificationPolicies != nil && len(o.NotificationPolicies) > 0 {
+	if len(o.NotificationPolicies) > 0 {
 		for _, notificationPolicy := range o.NotificationPolicies {
 			errAddNestedPolicy := grafanaClient.AddNestedPolicy(notificationPolicy)
 			if errAddNestedPolicy != nil {

observability-lib/grafana/dashboard_test.go

@@ -4,8 +4,9 @@ import (
 	"testing"
 
 	"github.com/grafana/grafana-foundation-sdk/go/expr"
-	"github.com/smartcontractkit/chainlink-common/observability-lib/grafana"
 	"github.com/stretchr/testify/require"
+
+	"github.com/smartcontractkit/chainlink-common/observability-lib/grafana"
 )
 
 func TestGenerateJSON(t *testing.T) {
@@ -83,6 +84,7 @@ func TestGenerateJSON(t *testing.T) {
 		}
 
 		json, err := o.GenerateJSON()
+		require.NoError(t, err)
 		require.IsType(t, json, []byte{})
 	})
 }

observability-lib/grafana/panels.go

@@ -440,7 +440,7 @@ func NewTimeSeriesPanel(options *TimeSeriesPanelOptions) *Panel {
 	}
 
 	var alertBuilders []*alerting.RuleBuilder
-	if options.AlertsOptions != nil && len(options.AlertsOptions) > 0 {
+	if len(options.AlertsOptions) > 0 {
 		for _, alert := range options.AlertsOptions {
 			// this is used as an internal mechanism to set the panel title in the alert to associate panelId with alert
 			alert.PanelTitle = *options.Title