cre-1601: remove previous outcome, use outctx.SeqNr instead

Author: mchain0

pkg/workflows/shardorchestrator/plugin.go

@@ -100,20 +100,6 @@ func (p *Plugin) ObservationQuorum(_ context.Context, _ ocr3types.OutcomeContext
 }
 
 func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ types.Query, aos []types.AttributedObservation) (ocr3types.Outcome, error) {
-	prevOutcome := &pb.Outcome{}
-	if err := proto.Unmarshal(outctx.PreviousOutcome, prevOutcome); err != nil || prevOutcome.State == nil {
-		p.lggr.Warnf("failed to unmarshal previous outcome or state is nil")
-		prevOutcome = &pb.Outcome{
-			State: &pb.RoutingState{
-				Id: 0,
-				State: &pb.RoutingState_RoutableShards{
-					RoutableShards: p.minShardCount,
-				},
-			},
-			Routes: make(map[string]*pb.WorkflowRoute),
-		}
-	}
-
 	currentShardHealth := make(map[uint32]int)
 	totalObservations := len(aos)
 	allWorkflows := []string{}
@@ -177,7 +163,7 @@ func (p *Plugin) Outcome(_ context.Context, outctx ocr3types.OutcomeContext, _ t
 	// Update routing state
 	outcome := &pb.Outcome{
 		State: &pb.RoutingState{
-			Id: prevOutcome.State.Id + 1,
+			Id: outctx.SeqNr,
 			State: &pb.RoutingState_RoutableShards{
 				RoutableShards: healthyShardCount,
 			},

pkg/workflows/shardorchestrator/plugin_test.go

@@ -30,7 +30,7 @@ func TestPlugin_OutcomeWithMultiNodeObservations(t *testing.T) {
 	require.NoError(t, err)
 
 	ctx := t.Context()
-	outcomeCtx := ocr3types.OutcomeContext{PreviousOutcome: []byte("")}
+	outcomeCtx := ocr3types.OutcomeContext{SeqNr: 42}
 
 	// Observations from 4 NOPs reporting health and workflows
 	observations := []struct {
@@ -87,6 +87,7 @@ func TestPlugin_OutcomeWithMultiNodeObservations(t *testing.T) {
 	require.NoError(t, err)
 
 	// Check consensus results
+	require.Equal(t, uint64(42), outcomeProto.State.Id, "ID should match SeqNr")
 	t.Logf("Outcome - ID: %d, HealthyShards: %d", outcomeProto.State.Id, outcomeProto.State.GetRoutableShards())
 	t.Logf("Workflows assigned: %d", len(outcomeProto.Routes))