Remove triggerID from AckEvent

Author: DylanTinianov

pkg/capabilities/base_trigger.go

@@ -0,0 +1,24 @@
+package capabilities
+
+import "time"
+
+// TODO Implement BaseTriggerCapability - CRE-1523
+
+type BaseTriggerCapability struct {
+	/*
+	 Keeps track of workflow registrations (similar to LLO streams trigger).
+	 Handles retransmits based on T_retransmit and T_max.
+	 Persists pending events in the DB to be resilient to node restarts.
+	*/
+
+	retransmitTime  time.Duration // time window for an event being ACKd before we retransmit
+	maxEventTimeout time.Duration // timeout before events are considered lost if not ACKd
+}
+
+func (*BaseTriggerCapability) deliverEvent(event *TriggerEvent, workflowIDs []string) error {
+	/*
+	 Base Trigger Capability can interact with the Don2Don layer (in the remote capability setting)
+	 as well as directly with a consumer (in the local setting).
+	*/
+	return nil // only when the event is successfully persisted and ready to be relaibly delivered
+}

pkg/capabilities/capabilities.go

@@ -338,34 +338,12 @@ type OCRAttributedOnchainSignature struct {
 type TriggerExecutable interface {
 	RegisterTrigger(ctx context.Context, request TriggerRegistrationRequest) (<-chan TriggerResponse, error)
 	UnregisterTrigger(ctx context.Context, request TriggerRegistrationRequest) error
-	AckEvent(ctx context.Context, triggerId string, eventId string) error
-}
-
-type BaseTriggerCapability interface {
-	/*
-	 Keeps track of workflow registrations (similar to LLO streams trigger).
-	 Handles retransmits based on T_retransmit and T_max.
-	 Persists pending events in the DB to be resilient to node restarts.
-	*/
-	deliverEvent(event *TriggerEvent, workflowIDs []string) error
-}
-
-type BaseTriggerCapabilityImpl struct {
-	// TODO: Every Trigger Capability should use this common implementation
-}
-
-func (*BaseTriggerCapabilityImpl) deliverEvent(event *TriggerEvent, workflowIDs []string) error {
-	/*
-	 Base Trigger Capability can interact with the Don2Don layer (in the remote capability setting)
-	 as well as directly with a consumer (in the local setting).
-	*/
-	return nil // only when the event is successfully persisted and ready to be reliably delivered
+	AckEvent(ctx context.Context, eventId string) error
 }
 
 // TriggerCapability interface needs to be implemented by all trigger capabilities.
 type TriggerCapability interface {
 	BaseCapability
-	BaseTriggerCapability
 	TriggerExecutable
 }