Skip to content

Commit f46f895

Browse files
committed
update standard cap initialise to take a struct
1 parent 415d51d commit f46f895

File tree

13 files changed

+76
-55
lines changed

13 files changed

+76
-55
lines changed

pkg/capabilities/v2/actions/http/client.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/actions/http/server/client_server_gen.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/consensus/consensus.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/consensus/server/consensus_server_gen.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/protoc/pkg/templates/server.go.tmpl

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ type {{.GoName}}Capability interface {
5353
Name() string
5454
Description() string
5555
Ready() error
56-
Initialise(ctx context.Context, config string, telemetryService core.TelemetryService, store core.KeyValueStore, errorLog core.ErrorLog, pipelineRunner core.PipelineRunnerService, relayerSet core.RelayerSet, oracleFactory core.OracleFactory, gatewayConnector core.GatewayConnector, p2pKeyValueStore core.Keystore) error
56+
Initialise(ctx context.Context, services core.StandardCapabilitiesServices) error
5757
}
5858

5959
func New{{.GoName}}Server(capability {{.GoName}}Capability) *{{.GoName}}Server {
@@ -71,14 +71,14 @@ type {{.GoName}}Server struct {
7171
}
7272

7373

74-
func (c *{{.GoName}}Server) Initialise(ctx context.Context, config string, telemetryService core.TelemetryService, store core.KeyValueStore, capabilityRegistry core.CapabilitiesRegistry, errorLog core.ErrorLog, pipelineRunner core.PipelineRunnerService, relayerSet core.RelayerSet, oracleFactory core.OracleFactory, gatewayConnector core.GatewayConnector, p2pKeystore core.Keystore) error {
75-
if err := c.{{.GoName}}Capability.Initialise(ctx, config, telemetryService, store, errorLog, pipelineRunner, relayerSet, oracleFactory, gatewayConnector, p2pKeystore); err != nil {
74+
func (c *{{.GoName}}Server) Initialise(ctx context.Context, services core.StandardCapabilitiesServices) error {
75+
if err := c.{{.GoName}}Capability.Initialise(ctx, services); err != nil {
7676
return fmt.Errorf("error when initializing capability: %w", err)
7777
}
7878

79-
c.capabilityRegistry = capabilityRegistry
79+
c.capabilityRegistry = services.CapabilityRegistry
8080

81-
if err := capabilityRegistry.Add(ctx, &{{.GoName|LowerFirst}}Capability{
81+
if err := services.CapabilityRegistry.Add(ctx, &{{.GoName|LowerFirst}}Capability{
8282
{{.GoName}}Capability: c.{{.GoName}}Capability,
8383
}); err != nil {
8484
return fmt.Errorf("error when adding kv store action to the registry: %w", err)

pkg/capabilities/v2/triggers/cron/server/trigger_server_gen.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/triggers/cron/trigger.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/triggers/http/server/trigger_server_gen.go

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/capabilities/v2/triggers/http/trigger.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/loop/internal/core/services/capability/standard/standard_capabilities.go

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,7 @@ import (
3131

3232
type StandardCapabilities interface {
3333
services.Service
34-
Initialise(ctx context.Context, config string, telemetryService core.TelemetryService, store core.KeyValueStore,
35-
capabilityRegistry core.CapabilitiesRegistry, errorLog core.ErrorLog,
36-
pipelineRunner core.PipelineRunnerService, relayerSet core.RelayerSet, oracleFactory core.OracleFactory,
37-
gatewayConnector core.GatewayConnector, p2pKeystore core.Keystore) error
34+
Initialise(ctx context.Context, services core.StandardCapabilitiesServices) error
3835
Infos(ctx context.Context) ([]capabilities.CapabilityInfo, error)
3936
}
4037

@@ -60,10 +57,18 @@ func NewStandardCapabilitiesClient(brokerCfg net.BrokerConfig) *StandardCapabili
6057
}
6158
}
6259

63-
func (c *StandardCapabilitiesClient) Initialise(ctx context.Context, config string, telemetryService core.TelemetryService,
64-
keyValueStore core.KeyValueStore, capabilitiesRegistry core.CapabilitiesRegistry, errorLog core.ErrorLog,
65-
pipelineRunner core.PipelineRunnerService, relayerSet core.RelayerSet, oracleFactory core.OracleFactory,
66-
gatewayConnector core.GatewayConnector, p2pKeystore core.Keystore) error {
60+
func (c *StandardCapabilitiesClient) Initialise(ctx context.Context, services core.StandardCapabilitiesServices) error {
61+
// Extract services from struct
62+
config := services.Config
63+
telemetryService := services.TelemetryService
64+
keyValueStore := services.Store
65+
capabilitiesRegistry := services.CapabilityRegistry
66+
errorLog := services.ErrorLog
67+
pipelineRunner := services.PipelineRunner
68+
relayerSet := services.RelayerSet
69+
oracleFactory := services.OracleFactory
70+
gatewayConnector := services.GatewayConnector
71+
p2pKeystore := services.P2PKeystore
6772
telemetryID, telemetryRes, err := c.ServeNew("Telemetry", func(s *grpc.Server) {
6873
pb.RegisterTelemetryServer(s, telemetry.NewTelemetryServer(telemetryService))
6974
})
@@ -306,7 +311,21 @@ func (s *standardCapabilitiesServer) Initialise(ctx context.Context, request *ca
306311
resources = append(resources, net.Resource{Closer: gatewayConnectorConn, Name: "GatewayConnector"})
307312
gatewayConnector := gateway.NewGatewayConnectorClient(gatewayConnectorConn, s.BrokerExt)
308313

309-
if err = s.impl.Initialise(ctx, request.Config, telemetry, keyValueStore, capabilitiesRegistry, errorLog, pipelineRunner, relayerSet, oracleFactory, gatewayConnector, keyStore); err != nil {
314+
// Construct the StandardCapabilitiesServices struct
315+
services := core.StandardCapabilitiesServices{
316+
Config: request.Config,
317+
TelemetryService: telemetry,
318+
Store: keyValueStore,
319+
CapabilityRegistry: capabilitiesRegistry,
320+
ErrorLog: errorLog,
321+
PipelineRunner: pipelineRunner,
322+
RelayerSet: relayerSet,
323+
OracleFactory: oracleFactory,
324+
GatewayConnector: gatewayConnector,
325+
P2PKeystore: keyStore,
326+
}
327+
328+
if err = s.impl.Initialise(ctx, services); err != nil {
310329
s.CloseAll(resources...)
311330
return nil, fmt.Errorf("failed to initialise standard capability: %w", err)
312331
}

0 commit comments

Comments
 (0)