chore(cldf): bump golang version (#677)

Chainlink core is already on this version
https://github.com/smartcontractkit/chainlink/blob/develop/go.mod

This pull request updates the development environment to use newer
versions of Go and golangci-lint across the project. These changes
ensure compatibility with the latest features, improvements, and
security updates for both tools.

**Development environment updates:**

* Upgraded Go version from `1.24.5` to `1.25.5` in `.tool-versions` and
`go.mod` to leverage the latest language features and improvements.
[[1]](diffhunk://#diff-751af1a340658c7b8176fe32d7db9fadbe15d1d075daba1919a91df04155bc70L1-R2)
[[2]](diffhunk://#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6L3-R3)
* Updated `golangci-lint` version from `2.5.0` to `2.8.0` in
`.tool-versions` and in the GitHub Actions workflows
(`pull-request-main.yml` and `schedule-main.yml`) to use the latest
linter checks and bug fixes.
[[1]](diffhunk://#diff-751af1a340658c7b8176fe32d7db9fadbe15d1d075daba1919a91df04155bc70L1-R2)
[[2]](diffhunk://#diff-deba6b8d69fe72e6186b64f7934e93aa1d8213648ef0e99400caa36df42883f0L22-R22)
[[3]](diffhunk://#diff-00a5b2e5be70dc0f682c3126e90a59bb428b0cbceafea6e65cf428baaeeb231fL22-R22)

---------

Co-authored-by: Copilot <[email protected]>

Author: ecPablo

.github/workflows/pull-request-main.yml

@@ -19,7 +19,7 @@ jobs:
         uses: smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/v2 # [email protected]
         with:
           only-new-issues: "false"
-          golangci-lint-version: v2.5.0
+          golangci-lint-version: v2.8.0
 
   ci-lint-misc:
     name: Lint GH Actions and scripts
@@ -101,18 +101,18 @@ jobs:
             --query 'reverse(sort_by(imageDetails,& imagePushedAt))' \
             --output json | \
             jq -r '
-              [.[] | 
-               select(.imageTags != null) | 
-               .imageTags[] | 
+              [.[] |
+               select(.imageTags != null) |
+               .imageTags[] |
                select(test("^v[0-9]+\\.[0-9]+\\.[0-9]+$"))
               ] | first
             ')
-          
+
           if [[ -z "${LATEST_TAG}" ]] || [[ "${LATEST_TAG}" == "null" ]]; then
             echo "::error::Could not find a valid semantic version tag in ECR"
             exit 1
           fi
-          
+
           echo "Latest catalog service tag from ECR: ${LATEST_TAG}"
           echo "tag=${LATEST_TAG}" >> "${GITHUB_OUTPUT}"
 

.github/workflows/schedule-main.yml

@@ -19,7 +19,7 @@ jobs:
         uses: smartcontractkit/.github/actions/ci-lint-go@ci-lint-go/v2 # [email protected]
         with:
           only-new-issues: "false"
-          golangci-lint-version: v2.5.0
+          golangci-lint-version: v2.8.0
 
   ci-lint-misc:
     name: Lint GH Actions and scripts
@@ -97,18 +97,18 @@ jobs:
             --query 'reverse(sort_by(imageDetails,& imagePushedAt))' \
             --output json | \
             jq -r '
-              [.[] | 
-               select(.imageTags != null) | 
-               .imageTags[] | 
+              [.[] |
+               select(.imageTags != null) |
+               .imageTags[] |
                select(test("^v[0-9]+\\.[0-9]+\\.[0-9]+$"))
               ] | first
             ')
-          
+
           if [[ -z "${LATEST_TAG}" ]] || [[ "${LATEST_TAG}" == "null" ]]; then
             echo "::error::Could not find a valid semantic version tag in ECR"
             exit 1
           fi
-          
+
           echo "Latest catalog service tag from ECR: ${LATEST_TAG}"
           echo "tag=${LATEST_TAG}" >> "${GITHUB_OUTPUT}"
 

.tool-versions

@@ -1,5 +1,5 @@
-golang        1.24.5
-golangci-lint 2.5.0
+golang        1.25.5
+golangci-lint 2.8.0
 mockery       3.3.4
 nodejs        20.16.0
 pnpm          10.6.5

chain/evm/provider/zksync_ctf_provider.go

@@ -244,7 +244,7 @@ func (p *ZkSyncCTFChainProvider) getTransactors(
 		require.FailNowf(p.t, "failed to parse chain ID into big.Int: %s", chainID)
 	}
 
-	transactors := make([]*bind.TransactOpts, 0)
+	transactors := make([]*bind.TransactOpts, 0, len(blockchain.AnvilZKSyncRichAccountPks))
 	for _, pk := range blockchain.AnvilZKSyncRichAccountPks {
 		privateKey, err := crypto.HexToECDSA(pk)
 		require.NoError(p.t, err)

datastore/memory_address_ref_store.go

@@ -52,7 +52,7 @@ func (s *MemoryAddressRefStore) Fetch() ([]AddressRef, error) {
 	s.mu.RLock()
 	defer s.mu.RUnlock()
 
-	records := []AddressRef{}
+	records := make([]AddressRef, 0, len(s.Records))
 	for _, record := range s.Records {
 		records = append(records, record.Clone())
 	}

engine/cld/legacy/cli/commands/jd_helper.go

@@ -70,7 +70,7 @@ func listProposalsByNodeId(
 
 // toNodeIDs maps nodes into slice of IDs.
 func toNodeIDs(nodes []*nodev1.Node) []string {
-	nodeIDs := make([]string, 0)
+	nodeIDs := make([]string, 0, len(nodes))
 	for _, ni := range nodes {
 		nodeIDs = append(nodeIDs, ni.Id)
 	}
@@ -80,7 +80,7 @@ func toNodeIDs(nodes []*nodev1.Node) []string {
 
 // toJobIDs maps job slice into slice of IDs.
 func toJobIDs(jobs []*jobv1.Job) []string {
-	ids := make([]string, 0)
+	ids := make([]string, 0, len(jobs))
 	for _, j := range jobs {
 		ids = append(ids, j.Id)
 	}
@@ -94,7 +94,7 @@ func toNodeViews(
 	nidToProposals map[string][]*jobv1.Proposal,
 	nidToJobs map[string][]*jobv1.Job,
 ) []NodeView {
-	nvs := make([]NodeView, 0)
+	nvs := make([]NodeView, 0, len(ns))
 	for _, n := range ns {
 		jobsView := toJobsView(n, nidToProposals, nidToJobs)
 		nvs = append(nvs, NodeView{
@@ -153,7 +153,7 @@ func writeNodeTable(nodes []*nodev1.Node) {
 	for _, node := range nodes {
 		labelsString := &strings.Builder{}
 		labelsTable := tablewriter.NewWriter(labelsString)
-		var labels [][]string
+		labels := make([][]string, 0, len(node.Labels))
 		for _, label := range node.Labels {
 			labels = append(labels, []string{label.Key, *label.Value})
 		}
@@ -178,7 +178,9 @@ func writeNodeTable(nodes []*nodev1.Node) {
 		if len(node.P2PKeyBundles) > 0 {
 			p2pBuilder := &strings.Builder{}
 			p2pTable := tablewriter.NewWriter(p2pBuilder)
-			var p2pData [][]string
+			// Pre-allocate capacity for 2 rows per P2PKeyBundle (Peer ID and Public Key).
+			// If the number of rows per bundle changes, update this multiplier accordingly.
+			p2pData := make([][]string, 0, len(node.P2PKeyBundles)*2)
 			for _, p2p := range node.P2PKeyBundles {
 				p2pData = append(p2pData, []string{"Peer ID", p2p.PeerId})
 				p2pData = append(p2pData, []string{"Public Key", p2p.PublicKey})

engine/cld/legacy/cli/commands/template_input.go

@@ -31,14 +31,15 @@ changesets:
 `, envKey, domainName)
 
 	// Generate each changeset section
+	var yamlTemplateSb34 strings.Builder
 	for i, changesetName := range changesetNames {
 		if changesetName == "" {
 			continue
 		}
 
 		// Add separator between changesets
 		if i > 0 {
-			yamlTemplate += "\n  # ----------------------------------------\n"
+			yamlTemplateSb34.WriteString("\n  # ----------------------------------------\n")
 		}
 
 		// Get changeset configuration
@@ -53,8 +54,9 @@ changesets:
 			return "", fmt.Errorf("generate section for changeset %s: %w", changesetName, err)
 		}
 
-		yamlTemplate += changesetSection
+		yamlTemplateSb34.WriteString(changesetSection)
 	}
+	yamlTemplate += yamlTemplateSb34.String()
 
 	return yamlTemplate, nil
 }

engine/cld/legacy/cli/templates.go

@@ -35,7 +35,7 @@ func (s normalizer) trim() normalizer {
 }
 
 func (s normalizer) indent() normalizer {
-	indentedLines := []string{}
+	indentedLines := make([]string, 0, strings.Count(s.string, "\n")+1)
 	for line := range strings.SplitSeq(s.string, "\n") {
 		trimmed := strings.TrimSpace(line)
 		indented := Indentation + trimmed

go.mod

@@ -1,6 +1,6 @@
 module github.com/smartcontractkit/chainlink-deployments-framework
 
-go 1.24.5
+go 1.25.5
 
 replace github.com/fbsobreira/gotron-sdk => github.com/smartcontractkit/chainlink-tron/relayer/gotron-sdk v0.0.4