fix: add timestamp to proposal name (#319)

As raised by
[Gustavo](https://chainlink-core.slack.com/archives/C08QF1BEW4T/p1756192076197519),
this changed was missed when migrating from CLD to CLDF, adding it back.

- added code back
- extended the tests to cover the new use case.

Author: graham-chainlink

.changeset/fine-jars-decide.md

@@ -0,0 +1,5 @@
+---
+"chainlink-deployments-framework": patch
+---
+
+add prefix to proposal if timestamp is available

engine/cld/domain/artifacts.go

@@ -676,13 +676,19 @@ func (a *ArtifactsDir) saveArtifact(k ksuid.KSUID, migKey, name string, v any) e
 // saveProposalArtifact writes a proposal artifact as JSON to the specified migration directory.
 func (a *ArtifactsDir) saveProposalArtifact(migkey string, name string, index int, v any) error {
 	filename := fmt.Sprintf("%s-%s-%s_%s_%d.%s", a.DomainKey(), a.EnvKey(), migkey, name, index, JSONExt)
+	if a.timestamp != "" {
+		filename = fmt.Sprintf("%s-%s", a.timestamp, filename)
+	}
 
 	return jsonutils.WriteFile(filepath.Join(a.getProposalDir(), filename), v)
 }
 
 // saveDecodedProposalArtifact writes a decoded proposal artifact as JSON to the specified migration directory.
 func (a *ArtifactsDir) saveDecodedProposalArtifact(migkey string, name string, index int, data string) error {
 	filename := fmt.Sprintf("%s-%s-%s_%s_%d_decoded.%s", a.DomainKey(), a.EnvKey(), migkey, name, index, TxtExt)
+	if a.timestamp != "" {
+		filename = fmt.Sprintf("%s-%s", a.timestamp, filename)
+	}
 
 	return os.WriteFile(filepath.Join(a.getDecodedProposalDir(), filename), []byte(data), 0600)
 }

engine/cld/domain/artifacts_test.go

@@ -3,6 +3,7 @@ package domain
 import (
 	"encoding/json"
 	"errors"
+	"fmt"
 	"os"
 	"path/filepath"
 	"sort"
@@ -1020,10 +1021,6 @@ func Test_Artifacts_SaveAndLoadOperationsReport(t *testing.T) {
 func Test_Artifacts_SaveAndLoadMultipleProposals(t *testing.T) {
 	t.Parallel()
 
-	fixture := setupTestDomainsFS(t)
-	migrationKey := "0001_initial"
-	artsDir := fixture.artifactsDir
-
 	validUntilUnixTime := uint32(time.Now().Add(time.Hour).Unix()) //nolint:gosec // This won't overflow until 7 Feb 2106, and would also cause MCMS to fail anyway
 
 	proposals := []mcmsv2.Proposal{
@@ -1071,38 +1068,103 @@ func Test_Artifacts_SaveAndLoadMultipleProposals(t *testing.T) {
 		},
 	}
 
-	// Save multiple proposals
-	require.NoError(t, artsDir.CreateMigrationDir(migrationKey))
-	for i, proposal := range proposals {
-		err := artsDir.saveProposalArtifact(migrationKey, ArtifactMCMSProposal, i, proposal)
-		require.NoError(t, err)
-		err = artsDir.saveDecodedProposalArtifact(migrationKey, ArtifactMCMSProposal, i, "some decoded proposal")
-		require.NoError(t, err)
+	tests := []struct {
+		name               string
+		migrationKey       string
+		setupFunc          func(t *testing.T, artsDir *ArtifactsDir)
+		expectedFilePrefix string
+		isDurablePipelines bool
+	}{
+		{
+			name:               "regular migration proposals",
+			migrationKey:       "0001_initial",
+			expectedFilePrefix: "",
+			isDurablePipelines: false,
+		},
+		{
+			name:         "durable pipelines proposals with timestamp prefix",
+			migrationKey: "0001_initial",
+			setupFunc: func(t *testing.T, artsDir *ArtifactsDir) {
+				t.Helper()
+				err := artsDir.SetDurablePipelines("1234567890123456789")
+				require.NoError(t, err)
+			},
+			expectedFilePrefix: "1234567890123456789-",
+			isDurablePipelines: true,
+		},
 	}
 
-	// Verify proposal files were created with correct indexes
-	files, err := os.ReadDir(artsDir.ProposalsDirPath())
-	sort.Slice(files, func(i, j int) bool { return files[i].Name() < files[j].Name() })
-	require.NoError(t, err)
-	assert.Len(t, files, len(proposals))
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
 
-	for i, file := range files {
-		assert.Contains(t, file.Name(), migrationKey)
-		assert.Contains(t, file.Name(), ArtifactMCMSProposal)
-		assert.Contains(t, file.Name(), "_"+strconv.Itoa(i))
-	}
+			fixture := setupTestDomainsFS(t)
+			artsDir := fixture.artifactsDir
 
-	// Load proposals and verify
-	exists, err := artsDir.MigrationDirExists(migrationKey)
-	require.NoError(t, err)
-	require.True(t, exists)
-	loadedProposals, err := artsDir.LoadChangesetOutput(migrationKey)
-	require.NoError(t, err)
-	assert.Len(t, loadedProposals.MCMSProposals, len(proposals))
+			if tt.setupFunc != nil {
+				tt.setupFunc(t, artsDir)
+			}
+
+			// Save multiple proposals
+			require.NoError(t, artsDir.CreateMigrationDir(tt.migrationKey))
+			for i, proposal := range proposals {
+				err := artsDir.saveProposalArtifact(tt.migrationKey, ArtifactMCMSProposal, i, proposal)
+				require.NoError(t, err)
+				err = artsDir.saveDecodedProposalArtifact(tt.migrationKey, ArtifactMCMSProposal, i, "some decoded proposal")
+				require.NoError(t, err)
+			}
+
+			// Verify proposal files were created with correct indexes and timestamp prefix
+			proposalFiles, err := os.ReadDir(artsDir.ProposalsDirPath())
+			require.NoError(t, err)
+			sort.Slice(proposalFiles, func(i, j int) bool { return proposalFiles[i].Name() < proposalFiles[j].Name() })
+			assert.Len(t, proposalFiles, len(proposals))
+
+			// Verify decoded proposal files were created
+			decodedFiles, err := os.ReadDir(artsDir.DecodedProposalsDirPath())
+			require.NoError(t, err)
+			sort.Slice(decodedFiles, func(i, j int) bool { return decodedFiles[i].Name() < decodedFiles[j].Name() })
+			assert.Len(t, decodedFiles, len(proposals))
+
+			// Check proposal file naming conventions
+			for i, file := range proposalFiles {
+				expectedFileName := fmt.Sprintf("%s%s-%s-%s_%s_%d.%s",
+					tt.expectedFilePrefix,
+					artsDir.DomainKey(),
+					artsDir.EnvKey(),
+					tt.migrationKey,
+					ArtifactMCMSProposal,
+					i,
+					JSONExt)
+				assert.Equal(t, expectedFileName, file.Name())
+			}
+
+			// Check decoded proposal file naming conventions
+			for i, file := range decodedFiles {
+				expectedFileName := fmt.Sprintf("%s%s-%s-%s_%s_%d_decoded.%s",
+					tt.expectedFilePrefix,
+					artsDir.DomainKey(),
+					artsDir.EnvKey(),
+					tt.migrationKey,
+					ArtifactMCMSProposal,
+					i,
+					TxtExt)
+				assert.Equal(t, expectedFileName, file.Name())
+			}
 
-	for i, proposal := range loadedProposals.MCMSProposals {
-		assert.Equal(t, proposals[i].Version, proposal.Version)
-		assert.Equal(t, proposals[i].ValidUntil, proposal.ValidUntil)
+			// Load proposals and verify
+			exists, err := artsDir.MigrationDirExists(tt.migrationKey)
+			require.NoError(t, err)
+			require.True(t, exists)
+			loadedProposals, err := artsDir.LoadChangesetOutput(tt.migrationKey)
+			require.NoError(t, err)
+			assert.Len(t, loadedProposals.MCMSProposals, len(proposals))
+
+			for i, proposal := range loadedProposals.MCMSProposals {
+				assert.Equal(t, proposals[i].Version, proposal.Version)
+				assert.Equal(t, proposals[i].ValidUntil, proposal.ValidUntil)
+			}
+		})
 	}
 }