Skip to content

Commit b43354c

Browse files
committed
fix: rename to GetProposalPRViews
1 parent 48150d0 commit b43354c

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

experimental/proposalutils/predecessors/github_ops.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ import (
1717
type ProposalPRFinder interface {
1818
SearchOpen(ctx context.Context, title string) ([]*github.Issue, error)
1919
FindPredecessors(ctx context.Context, newPRViewData PRView, excludePRs []PRNum) ([]PRView, error)
20-
GetPRViews(ctx context.Context, proposalPRs []*github.Issue) []PRView
20+
GetProposalPRViews(ctx context.Context, proposalPRs []*github.Issue) []PRView
2121
}
2222

2323
// GithubProposalPRFinder implements ProposalPRFinder using GitHub API.
@@ -103,7 +103,7 @@ func (f *GithubProposalPRFinder) FindPredecessors(
103103
return nil, nil
104104
}
105105

106-
prViews := f.GetPRViews(ctx, proposalPRs)
106+
prViews := f.GetProposalPRViews(ctx, proposalPRs)
107107
prViews = filterSlice(prViews, func(prView PRView, _ int) bool { return !slices.Contains(excludePRs, prView.Number) })
108108
prViews = append(prViews, newPRViewData) // include the new PR
109109

@@ -120,8 +120,8 @@ func (f *GithubProposalPRFinder) FindPredecessors(
120120
return predViews, nil
121121
}
122122

123-
// GetPRViews fetches PR details and proposal op count data for the given issues.
124-
func (f *GithubProposalPRFinder) GetPRViews(
123+
// GetProposalPRViews fetches PR details and proposal op count data for the given issues.
124+
func (f *GithubProposalPRFinder) GetProposalPRViews(
125125
ctx context.Context,
126126
proposalPRs []*github.Issue,
127127
) []PRView {

experimental/proposalutils/predecessors/github_ops_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func TestGetPRViews(t *testing.T) {
119119
CreatedAt: &github.Timestamp{Time: created},
120120
}
121121

122-
views := finder.GetPRViews(t.Context(), []*github.Issue{issue})
122+
views := finder.GetProposalPRViews(t.Context(), []*github.Issue{issue})
123123
require.Len(t, views, 1)
124124
require.Equal(t, PRNum(10), views[0].Number)
125125
require.Equal(t, created.UTC().Truncate(time.Second), views[0].CreatedAt.UTC().Truncate(time.Second))

0 commit comments

Comments
 (0)