fixing test cases and docs

Author: pablolagreca

CONFIG.md

@@ -40,6 +40,8 @@ RPCBlockQueryDelay = 1 # Default
 FinalizedBlockOffset = 0 # Default
 LogBroadcasterEnabled = true # Default
 NoNewFinalizedHeadsThreshold = '0' # Default
+TxMinimumWaitTimeForConfirmation = '60s' # Default
+TxMaximumWaitTimeForConfirmation = '300s' # Default
 ```
 
 
@@ -267,6 +269,18 @@ out-of-sync. Only applicable if `FinalityTagEnabled=true`
 
 Set to zero to disable.
 
+### TxMinimumWaitTimeForConfirmation
+```toml
+TxMinimumWaitTimeForConfirmation = '60s' # Default
+```
+TxMinimumWaitTimeForConfirmation minimum time to wait for a TX to get into a block in the blockchain. This is used for the EVMService.SubmitTransaction operation. It won't check for TX status updates until this time passes
+
+### TxMaximumWaitTimeForConfirmation
+```toml
+TxMaximumWaitTimeForConfirmation = '300s' # Default
+```
+TxMaximumWaitTimeForConfirmation time after TxMinimumWaitTimeForConfirmation to wait for a TX to get into a block. After TxMinimumWaitTimeForConfirmation the operation will check every 100 milliseconds to see if the TX gets into a block and will do it for no longer than TxMaximumWaitTimeForConfirmation. Total wait time will be TxMinimumWaitTimeForConfirmation + TxMaximumWaitTimeForConfirmation
+
 ## Transactions
 ```toml
 [Transactions]

go.sum

@@ -654,7 +654,11 @@ github.com/smartcontractkit/chainlink-framework/capabilities v0.0.0-202505221100
 github.com/smartcontractkit/chainlink-framework/capabilities v0.0.0-20250522110034-65c54665034a/go.mod h1:NVoJQoPYr6BorpaXTusoIH1IYTySCmanQ8Q1yv3mNh4=
 <<<<<<< HEAD
 <<<<<<< HEAD
+<<<<<<< HEAD
 >>>>>>> e0f33af5de (fixing compilation issue)
+=======
+<<<<<<< HEAD
+>>>>>>> b6687cf564 (fixing test cases and docs)
 github.com/smartcontractkit/chainlink-framework/chains v0.0.0-20250616180023-87b70c08d7c0 h1:OpFlG2f+LXsDp3cejSQju2rmoNsxBlhgrwXMIsk72IA=
 github.com/smartcontractkit/chainlink-framework/chains v0.0.0-20250616180023-87b70c08d7c0/go.mod h1:X+a4k2a+2G2/yeAaRQMCTLmlhNdQYAeN6v+ZpLzRZww=
 <<<<<<< HEAD
@@ -664,9 +668,10 @@ github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250618135814-7e
 =======
 >>>>>>> a1239ddce6 (PLEX-250 - WriteReport initial implementation)
 =======
+=======
+>>>>>>> 30c81f8ea5 (fixing test cases and docs)
 github.com/smartcontractkit/chainlink-framework/chains v0.0.0-20250617131436-7c15436c29fd h1:7dEEuuLos8YlXI2AsnEfqLwTfUIawSF0WlknsJ4/Eog=
 github.com/smartcontractkit/chainlink-framework/chains v0.0.0-20250617131436-7c15436c29fd/go.mod h1:BLEQYCcR2mSSTdUqGxnvJ3bqwzQN7KjTBG1BDJwaXY4=
->>>>>>> c31efa585b (fixing compilation issue)
 github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250522110034-65c54665034a h1:bFYBcW0cmhq0G8NSjPxSFfL/fVODuhEGluyWOxJTqqk=
 github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250522110034-65c54665034a/go.mod h1:jo+cUqNcHwN8IF7SInQNXDZ8qzBsyMpnLdYbDswviFc=
 >>>>>>> 1ea3fe4233 (PLEX-250 - WriteReport initial implementation)

pkg/client/config_builder_test.go

@@ -28,7 +28,7 @@ func TestClientConfigBuilder(t *testing.T) {
 	deathDeclarationDelay := time.Second * 3
 	noNewFinalizedBlocksThreshold := time.Second
 	txMinimumWaitTimeForConfirmation := time.Second * 60
-	txMaximumWaitTimeForConfirmation := time.Second * 20
+	txMaximumWaitTimeForConfirmation := time.Second * 300
 	nodeConfigs := []client.NodeConfig{
 		{
 			Name:    ptr("foo"),

pkg/client/evm_client_test.go

@@ -40,7 +40,7 @@ func TestNewEvmClient(t *testing.T) {
 	finalizedBlockPollInterval := time.Second * 4
 	newHeadsPollInterval := time.Second * 4
 	txMinimumWaitTimeForConfirmation := time.Second * 60
-	txMaximumWaitTimeForConfirmation := time.Second * 20
+	txMaximumWaitTimeForConfirmation := time.Second * 300
 	nodeConfigs := []client.NodeConfig{
 		{
 			Name:    ptr("foo"),
@@ -79,7 +79,7 @@ func TestChainClientMetrics(t *testing.T) {
 	}
 	chainCfg, nodePool, nodes, err := client.NewClientConfigs(ptr("HighestHead"), time.Duration(0), "", nodeConfigs,
 		ptr[uint32](5), 10*time.Second, ptr[uint32](5), ptr(false), time.Minute, ptr[uint32](5), ptr(false),
-		ptr[uint32](5), ptr(false), 10*time.Second, 10*time.Second, 10*time.Second, 10*time.Second, 60*time.Second, 20*time.Second)
+		ptr[uint32](5), ptr(false), 10*time.Second, 10*time.Second, 10*time.Second, 10*time.Second, 60*time.Second, 300*time.Second)
 	require.NoError(t, err)
 
 	chainID := big.NewInt(68472)

pkg/config/toml/config_test.go

@@ -270,8 +270,8 @@ var fullConfig = EVMConfig{
 		RPCDefaultBatchSize:              ptr[uint32](17),
 		RPCBlockQueryDelay:               ptr[uint16](10),
 		NoNewFinalizedHeadsThreshold:     config.MustNewDuration(time.Hour),
-		TxMinimumWaitTimeForConfirmation: config.MustNewDuration(60 * time.Second),
-		TxMaximumWaitTimeForConfirmation: config.MustNewDuration(20 * time.Second),
+		TxMinimumWaitTimeForConfirmation: config.MustNewDuration(1 * time.Minute),
+		TxMaximumWaitTimeForConfirmation: config.MustNewDuration(5 * time.Minute),
 
 		Transactions: Transactions{
 			Enabled:              ptr(true),

pkg/config/toml/defaults/fallback.toml

@@ -18,8 +18,8 @@ RPCBlockQueryDelay = 1
 FinalizedBlockOffset = 0
 NoNewFinalizedHeadsThreshold = '0'
 LogBroadcasterEnabled = true
-TxMinimumWaitTimeForConfirmation = '60s'
-TxMaximumWaitTimeForConfirmation = '20s'
+TxMinimumWaitTimeForConfirmation = '1m0s'
+TxMaximumWaitTimeForConfirmation = '5m0s'
 
 [Transactions]
 Enabled = true

pkg/config/toml/docs.toml

@@ -118,12 +118,10 @@ LogBroadcasterEnabled = true # Default
 #
 # Set to zero to disable.
 NoNewFinalizedHeadsThreshold = '0' # Default
-# Minimum time to wait for a TX to get into a block in the blockchain. This is used for the EVMService.SubmitTransaction operation. It won't check for TX status updates until this time passes
-TxMinimumWaitTimeForConfirmation = '60s'
-# TODO: Find a proper name
-# Maximum time after TxMinimumWaitTimeForConfirmation to wait for a TX to get into a block. After TxMinimumWaitTimeForConfirmation the operation will check every 100 milliseconds to see if the TX gets into a block and will do it for no longer than TxMaximumWaitTimeForConfirmation. Total wait time will be TxMinimumWaitTimeForConfirmation + TxMaximumWaitTimeForConfirmation
-TxMaximumWaitTimeForConfirmation = '20s'
-
+# TxMinimumWaitTimeForConfirmation minimum time to wait for a TX to get into a block in the blockchain. This is used for the EVMService.SubmitTransaction operation. It won't check for TX status updates until this time passes
+TxMinimumWaitTimeForConfirmation = '60s' # Default
+# TxMaximumWaitTimeForConfirmation time after TxMinimumWaitTimeForConfirmation to wait for a TX to get into a block. After TxMinimumWaitTimeForConfirmation the operation will check every 100 milliseconds to see if the TX gets into a block and will do it for no longer than TxMaximumWaitTimeForConfirmation. Total wait time will be TxMinimumWaitTimeForConfirmation + TxMaximumWaitTimeForConfirmation
+TxMaximumWaitTimeForConfirmation = '300s' # Default
 
 [Transactions]
 # Enabled is a feature flag for the Transaction Manager. This flag also enables or disables the gas estimator since it is dependent on the TXM to start it.

pkg/config/toml/testdata/config-full.toml

@@ -24,7 +24,7 @@ RPCDefaultBatchSize = 17
 RPCBlockQueryDelay = 10
 FinalizedBlockOffset = 16
 NoNewFinalizedHeadsThreshold = '1h0m0s'
-TxMaximumWaitTimeForConfirmation = '20s'
+TxMaximumWaitTimeForConfirmation = '5m0s'
 TxMinimumWaitTimeForConfirmation = '1m0s'
 
 [Transactions]

pkg/heads/tracker.go

@@ -53,10 +53,4 @@ func (*nullTracker) LatestSafeBlock(ctx context.Context) (safe *evmtypes.Head, e
 }
 func (*nullTracker) LatestAndFinalizedBlock(ctx context.Context) (latest, finalized *evmtypes.Head, err error) {
 	return nil, nil, nil
-}
-
-func (*nullTracker) LatestSafeBlock(ctx context.Context) (safe *evmtypes.Head, err error) {
-	return nil, nil
-}
-
- 
+}