Revert metrics names

Author: DylanTinianov

multinode/multi_node.go

@@ -17,7 +17,7 @@ import (
 var (
 	// PromMultiNodeRPCNodeStates reports current RPC node state
 	PromMultiNodeRPCNodeStates = promauto.NewGaugeVec(prometheus.GaugeOpts{
-		Name: "multinode_states",
+		Name: "multi_node_states",
 		Help: "The number of RPC nodes currently in the given state for the given chain",
 	}, []string{"network", "chainId", "state"})
 	ErrNodeError = fmt.Errorf("no live nodes available")

multinode/node.go

@@ -21,15 +21,15 @@ var errInvalidChainID = errors.New("invalid chain id")
 
 var (
 	promPoolRPCNodeVerifies = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_verifies",
+		Name: "pool_rpc_node_verifies",
 		Help: "The total number of chain ID verifications for the given RPC node",
 	}, []string{"network", "chainID", "nodeName"})
 	promPoolRPCNodeVerifiesFailed = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_verifies_failed",
+		Name: "pool_rpc_node_verifies_failed",
 		Help: "The total number of failed chain ID verifications for the given RPC node",
 	}, []string{"network", "chainID", "nodeName"})
 	promPoolRPCNodeVerifiesSuccess = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_verifies_success",
+		Name: "pool_rpc_node_verifies_success",
 		Help: "The total number of successful chain ID verifications for the given RPC node",
 	}, []string{"network", "chainID", "nodeName"})
 )

multinode/node_fsm.go

@@ -9,31 +9,31 @@ import (
 
 var (
 	promPoolRPCNodeTransitionsToAlive = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_alive",
+		Name: "pool_rpc_node_num_transitions_to_alive",
 		Help: transitionString(nodeStateAlive),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToInSync = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_in_sync",
+		Name: "pool_rpc_node_num_transitions_to_in_sync",
 		Help: fmt.Sprintf("%s to %s", transitionString(nodeStateOutOfSync), nodeStateAlive),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToOutOfSync = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_out_of_sync",
+		Name: "pool_rpc_node_num_transitions_to_out_of_sync",
 		Help: transitionString(nodeStateOutOfSync),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToUnreachable = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_unreachable",
+		Name: "pool_rpc_node_num_transitions_to_unreachable",
 		Help: transitionString(nodeStateUnreachable),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToInvalidChainID = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_invalid_chain_id",
+		Name: "pool_rpc_node_num_transitions_to_invalid_chain_id",
 		Help: transitionString(nodeStateInvalidChainID),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToUnusable = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_unusable",
+		Name: "pool_rpc_node_num_transitions_to_unusable",
 		Help: transitionString(nodeStateUnusable),
 	}, []string{"chainID", "nodeName"})
 	promPoolRPCNodeTransitionsToSyncing = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_pool_rpc_node_num_transitions_to_syncing",
+		Name: "pool_rpc_node_num_transitions_to_syncing",
 		Help: transitionString(nodeStateSyncing),
 	}, []string{"chainID", "nodeName"})
 )

multinode/transaction_sender.go

@@ -18,7 +18,7 @@ import (
 var (
 	// PromMultiNodeInvariantViolations reports violation of our assumptions
 	PromMultiNodeInvariantViolations = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multinode_transaction_sender_invariant_violations",
+		Name: "multi_node_invariant_violations",
 		Help: "The number of invariant violations",
 	}, []string{"network", "chainId", "invariant"})
 )