Create generic metrics

Author: DylanTinianov

multinode/go.mod

@@ -10,7 +10,6 @@ require (
 	github.com/prometheus/client_golang v1.22.0
 	github.com/prometheus/client_model v0.6.1
 	github.com/smartcontractkit/chainlink-common v0.7.0
-	github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250425163146-e2685f8677f7
 	github.com/stretchr/testify v1.10.0
 	go.uber.org/zap v1.27.0
 )

multinode/go.sum

@@ -72,8 +72,6 @@ github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR
 github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
 github.com/smartcontractkit/chainlink-common v0.7.0 h1:QThOrHKn+du8CTmzJPCha0Nwnvw0tonIEAQca+dnmE0=
 github.com/smartcontractkit/chainlink-common v0.7.0/go.mod h1:pptbsF6z90IGCewkCgDMBxNYjfSOyW9X9l2jzYyQgmk=
-github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250425163146-e2685f8677f7 h1:s/wTwHj1C2IsW05vziADSHsrqTY2d33VRFZFsumQM9s=
-github.com/smartcontractkit/chainlink-framework/metrics v0.0.0-20250425163146-e2685f8677f7/go.mod h1:1D0TYbsfFFNVkPs5QAr5xV6aCpcGukQ+jgwh5G91Fu0=
 github.com/smartcontractkit/libocr v0.0.0-20250220133800-f3b940c4f298 h1:PKiqnVOTChlH4a4ljJKL3OKGRgYfIpJS4YD1daAIKks=
 github.com/smartcontractkit/libocr v0.0.0-20250220133800-f3b940c4f298/go.mod h1:Mb7+/LC4edz7HyHxX4QkE42pSuov4AV68+AxBXAap0o=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=

multinode/multi_node.go

@@ -10,11 +10,14 @@ import (
 
 	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/smartcontractkit/chainlink-common/pkg/services"
-	"github.com/smartcontractkit/chainlink-framework/metrics"
 )
 
 var ErrNodeError = fmt.Errorf("no live nodes available")
 
+type multiNodeMetrics interface {
+	RecordNodeStates(ctx context.Context, state string, count int64)
+}
+
 // MultiNode is a generalized multi node client interface that includes methods to interact with different chains.
 // It also handles multiple node RPC connections simultaneously.
 type MultiNode[
@@ -28,7 +31,7 @@ type MultiNode[
 	sendOnlyNodes         []SendOnlyNode[CHAIN_ID, RPC]
 	chainID               CHAIN_ID
 	lggr                  logger.SugaredLogger
-	metrics               metrics.GenericMultiNodeMetrics
+	metrics               multiNodeMetrics
 	selectionMode         string
 	nodeSelector          NodeSelector[CHAIN_ID, RPC]
 	leaseDuration         time.Duration
@@ -46,7 +49,7 @@ func NewMultiNode[
 	RPC any,
 ](
 	lggr logger.Logger,
-	metrics metrics.GenericMultiNodeMetrics,
+	metrics multiNodeMetrics,
 	selectionMode string, // type of the "best" RPC selector (e.g HighestHead, RoundRobin, etc.)
 	leaseDuration time.Duration, // defines interval on which new "best" RPC should be selected
 	primaryNodes []Node[CHAIN_ID, RPC],

multinode/node.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"github.com/smartcontractkit/chainlink-framework/metrics"
 	"net/url"
 	"sync"
 	"time"
@@ -38,6 +37,19 @@ type ChainConfig interface {
 	FinalizedBlockOffset() uint32
 }
 
+type nodeMetrics interface {
+	IncrementNodeVerifies(ctx context.Context, nodeName string)
+	IncrementNodeVerifiesFailed(ctx context.Context, nodeName string)
+	IncrementNodeVerifiesSuccess(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToAlive(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToInSync(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToOutOfSync(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToUnreachable(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToInvalidChainID(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToUnusable(ctx context.Context, nodeName string)
+	IncrementNodeTransitionsToSyncing(ctx context.Context, nodeName string)
+}
+
 type Node[
 	CHAIN_ID ID,
 	RPC any,
@@ -81,7 +93,7 @@ type node[
 	order       int32
 	chainFamily string
 
-	metrics metrics.GenericMultiNodeMetrics
+	metrics nodeMetrics
 
 	ws   *url.URL
 	http *url.URL
@@ -108,7 +120,7 @@ func NewNode[
 	nodeCfg NodeConfig,
 	chainCfg ChainConfig,
 	lggr logger.Logger,
-	metrics metrics.GenericMultiNodeMetrics,
+	metrics nodeMetrics,
 	wsuri *url.URL,
 	httpuri *url.URL,
 	name string,

multinode/transaction_sender.go

@@ -8,21 +8,10 @@ import (
 	"sync"
 	"time"
 
-	"github.com/prometheus/client_golang/prometheus"
-	"github.com/prometheus/client_golang/prometheus/promauto"
-
 	"github.com/smartcontractkit/chainlink-common/pkg/logger"
 	"github.com/smartcontractkit/chainlink-common/pkg/services"
 )
 
-var (
-	// PromMultiNodeInvariantViolations reports violation of our assumptions
-	PromMultiNodeInvariantViolations = promauto.NewCounterVec(prometheus.CounterOpts{
-		Name: "multi_node_invariant_violations",
-		Help: "The number of invariant violations",
-	}, []string{"network", "chainId", "invariant"})
-)
-
 type sendTxResult[RESULT any] struct {
 	res   RESULT
 	code  SendTxReturnCode
@@ -37,11 +26,16 @@ type SendTxRPCClient[TX any, RESULT any] interface {
 	SendTransaction(ctx context.Context, tx TX) (RESULT, SendTxReturnCode, error)
 }
 
+type transactionSenderMetrics interface {
+	IncrementInvariantViolations(ctx context.Context, invariant string)
+}
+
 func NewTransactionSender[TX any, RESULT any, CHAIN_ID ID, RPC SendTxRPCClient[TX, RESULT]](
 	lggr logger.Logger,
 	chainID CHAIN_ID,
 	chainFamily string,
 	multiNode *MultiNode[CHAIN_ID, RPC],
+	metrics transactionSenderMetrics,
 	classifyErr func(err error) SendTxReturnCode,
 	sendTxSoftTimeout time.Duration,
 ) *TransactionSender[TX, RESULT, CHAIN_ID, RPC] {
@@ -52,6 +46,7 @@ func NewTransactionSender[TX any, RESULT any, CHAIN_ID ID, RPC SendTxRPCClient[T
 		chainID:           chainID,
 		chainFamily:       chainFamily,
 		lggr:              logger.Sugared(lggr).Named("TransactionSender").With("chainID", chainID.String()),
+		metrics:           metrics,
 		multiNode:         multiNode,
 		classifyErr:       classifyErr,
 		sendTxSoftTimeout: sendTxSoftTimeout,
@@ -64,6 +59,7 @@ type TransactionSender[TX any, RESULT any, CHAIN_ID ID, RPC SendTxRPCClient[TX,
 	chainID           CHAIN_ID
 	chainFamily       string
 	lggr              logger.SugaredLogger
+	metrics           transactionSenderMetrics
 	multiNode         *MultiNode[CHAIN_ID, RPC]
 	classifyErr       func(err error) SendTxReturnCode
 	sendTxSoftTimeout time.Duration // defines max waiting time from first response til responses evaluation
@@ -199,7 +195,9 @@ func (txSender *TransactionSender[TX, RESULT, CHAIN_ID, RPC]) reportSendTxAnomal
 	_, criticalErr := aggregateTxResults(resultsByCode)
 	if criticalErr != nil {
 		txSender.lggr.Criticalw("observed invariant violation on SendTransaction", "tx", tx, "resultsByCode", resultsByCode, "err", criticalErr)
-		PromMultiNodeInvariantViolations.WithLabelValues(txSender.chainFamily, txSender.chainID.String(), criticalErr.Error()).Inc()
+		ctx, cancel := txSender.chStop.NewCtx()
+		defer cancel()
+		txSender.metrics.IncrementInvariantViolations(ctx, criticalErr.Error())
 	}
 }