Skip to content

Commit a488315

Browse files
Move encrypt_output from ConfidentialHTTPRequest to HTTPRequest (#291)
* Move encrypt_output from ConfidentialHTTPRequest to HTTPRequest encrypt_output is an HTTP request property, not a framework/secrets concern. Moving it into HTTPRequest (field 9) keeps encryption as a per-request setting alongside URL, method, headers, etc. * Auto-fix: buf format, gofmt, go generate, go mod tidy --------- Co-authored-by: app-token-issuer-engops[bot] <144731339+app-token-issuer-engops[bot]@users.noreply.github.com>
1 parent 087e235 commit a488315

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

cre/capabilities/networking/confidentialhttp/v1alpha/client.proto

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ message HTTPRequest {
3737
bytes custom_root_ca_cert_pem = 6;
3838
// timeout is the request timeout duration.
3939
google.protobuf.Duration timeout = 7;
40+
// encrypt_output controls whether the enclave response should be encrypted.
41+
// If true, the response will be AES-GCM encrypted using the
42+
// "san_marino_aes_gcm_encryption_key" secret.
43+
// Default is false (response returned unencrypted).
44+
bool encrypt_output = 9;
4045
}
4146

4247
// HTTPResponse contains the HTTP response from the enclave.
@@ -55,13 +60,6 @@ message HTTPResponse {
5560
message ConfidentialHTTPRequest {
5661
repeated SecretIdentifier vault_don_secrets = 1;
5762
HTTPRequest request = 2;
58-
// encrypt_output controls whether the enclave response should be encrypted.
59-
// If true and a secret named "san_marino_aes_gcm_encryption_key" is provided,
60-
// the response will be AES-GCM encrypted using that key.
61-
// If true and no such key is provided, the response will be TDH2 encrypted
62-
// using the VaultDON master public key.
63-
// Default is false (response returned unencrypted).
64-
bool encrypt_output = 3;
6563
}
6664

6765
service Client {

cre/go/installer/pkg/embedded_gen.go

Lines changed: 5 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)