Audit #2 (#1307)

* address runtime panics

* default pubkey not allowed as admin

* add checks for ownership

* fix typo

* standardize data.len check

* linting

* update transfer conditions

* fix pda creation

* fix pda creation set_decimal_feed_config

* make workflow metadata list smaller

* receiver program belongs in forwarder authority seeds

* verify account context hashes in report

* fix orphaned config/perm accounts

* beef up events

* clarify instruction limits

* add documentation for closing accounts

* add docstrings

* add doc for updating legacy feed inst

* docstrings for cache

* add cache struct documentation

* add forwarder docstrings

* efficient payload serialization

* simplify logic

* redundant sorting

* remove closed account discriminator

* remove unused errors

* todos complete

* fix documentation + add forwarder program id in cache state

* typos

* inconsistent naming

* use is_empty

* renaming items

* remove unused params

* simplify filtering

* compile-time assertion

* simplify feed admin

* reformat cache directory

* lint

* final report fixes

* fix typo + remove close_account

* fix seeds

* lint

* update generated bindings

* fix generated

* fix linter

* format

* add len-prefix to msg hash

* fix program id

---------

Co-authored-by: Vladimir <vladimir.shchukin@smartcontract.com>

Author: augustbleeds

contracts/crates/chainlink-solana-data-feeds-cache/src/lib.rs

@@ -2,6 +2,8 @@ use anchor_lang::prelude::*;
 use data_feeds_cache::state::WorkflowMetadata;
 use solana_program::account_info::AccountInfo;
 
+/// The data ids passed in must match the ordering of the decimal reports input.
+/// Developer is responsible for deriving the correct PDAs for the report before calling the function
 pub fn query_values<'info>(
     data_cache_program: AccountInfo<'info>,
     cache_state: AccountInfo<'info>,
@@ -18,6 +20,10 @@ pub fn query_values<'info>(
     Ok(values)
 }
 
+/// Returns a feed's workflow metadata. Chunks return values by `max_count`.
+/// Can be used on-chain to verify a feed's configuration.
+/// If `start_index` is out of bounds the function will return an empty array.
+/// If `max_count = 0` then function will return the entire workflow metadata list.
 pub fn query_feed_metadata<'info>(
     data_cache_program: AccountInfo<'info>,
     cache_state: AccountInfo<'info>,