More lint fixes

Author: lukaszcl

lib/client/rpc_suite_test.go

@@ -1,3 +1,4 @@
+// nolint
 package client
 
 import (

lib/client/rpc_test.go

@@ -1,3 +1,4 @@
+// nolint
 package client
 
 import (

lib/config/network.go

@@ -90,21 +90,21 @@ func (n *NetworkConfig) OverrideURLsAndKeysFromEVMNetwork() {
 		return
 	}
 	for name, evmNetwork := range n.EVMNetworks {
-		if evmNetwork.URLs != nil && len(evmNetwork.URLs) > 0 {
+		if len(evmNetwork.URLs) > 0 {
 			logging.L.Warn().Str("network", name).Msg("found URLs in EVMNetwork. overriding RPC URLs in RpcWsUrls with EVMNetwork URLs")
 			if n.RpcWsUrls == nil {
 				n.RpcWsUrls = make(map[string][]string)
 			}
 			n.RpcWsUrls[name] = evmNetwork.URLs
 		}
-		if evmNetwork.HTTPURLs != nil && len(evmNetwork.HTTPURLs) > 0 {
+		if len(evmNetwork.HTTPURLs) > 0 {
 			logging.L.Warn().Str("network", name).Msg("found HTTPURLs in EVMNetwork. overriding RPC URLs in RpcHttpUrls with EVMNetwork HTTP URLs")
 			if n.RpcHttpUrls == nil {
 				n.RpcHttpUrls = make(map[string][]string)
 			}
 			n.RpcHttpUrls[name] = evmNetwork.HTTPURLs
 		}
-		if evmNetwork.PrivateKeys != nil && len(evmNetwork.PrivateKeys) > 0 {
+		if len(evmNetwork.PrivateKeys) > 0 {
 			logging.L.Warn().Str("network", name).Msg("found PrivateKeys in EVMNetwork. overriding wallet keys in WalletKeys with EVMNetwork private keys")
 			if n.WalletKeys == nil {
 				n.WalletKeys = make(map[string][]string)

lib/config/testconfig_test.go

@@ -218,7 +218,7 @@ func TestValidateNetworkConfig(t *testing.T) {
 	}
 
 	for _, tc := range testCases {
-		tc := tc // capture range variable
+		tc := tc //nolint capture range variable
 		t.Run(tc.name, func(t *testing.T) {
 			err := tc.networkConfig.Validate()
 			if tc.expectedError != nil {

lib/docker/test_env/killgrave_test.go

@@ -1,3 +1,4 @@
+// nolint
 package test_env
 
 import (

lib/gauntlet/gauntlet.go

@@ -154,7 +154,7 @@ func (g *Gauntlet) ExecCommandWithRetries(args []string, options ExecCommandOpti
 		},
 		retry.Delay(options.RetryDelay),
 		retry.MaxDelay(options.RetryDelay),
-		retry.Attempts(uint(options.RetryCount)),
+		retry.Attempts(uint(options.RetryCount)), //nolint
 	)
 
 	return output, err

lib/logstream/logstream_test.go

@@ -1,3 +1,4 @@
+// nolint
 package logstream_test
 
 import (

lib/networks/known_networks_test.go

@@ -1,3 +1,4 @@
+// nolint
 package networks
 
 import (
@@ -82,10 +83,6 @@ func TestVariousNetworkConfig(t *testing.T) {
 	}
 	httpOnlyNetwork := newNetwork
 	httpOnlyNetwork.URLs = nil
-	forkedNetwork := newNetwork
-	forkedNetwork.HTTPURLs = nil
-	forkedNetwork.URLs = nil
-	forkedNetwork.PrivateKeys = nil
 	t.Cleanup(func() {
 		ArbitrumGoerli.URLs = []string{}
 		ArbitrumGoerli.HTTPURLs = []string{}

lib/utils/seth/seth.go

@@ -257,10 +257,10 @@ func ValidateSethNetworkConfig(cfg *pkg_seth.Network) error {
 	if cfg == nil {
 		return errors.New("network cannot be nil")
 	}
-	if cfg.URLs == nil || len(cfg.URLs) == 0 {
+	if len(cfg.URLs) == 0 {
 		return errors.New("URLs are required")
 	}
-	if cfg.PrivateKeys == nil || len(cfg.PrivateKeys) == 0 {
+	if len(cfg.PrivateKeys) == 0 {
 		return errors.New("PrivateKeys are required")
 	}
 	if cfg.TransferGasFee == 0 {